WIP - simplifying the stub

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
eclipse-theia · May 16, 2023 · f6cb9db · f6cb9db
1 parent ce3eb8f
commit f6cb9db
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/packages/plugin-ext/src/plugin/plugin-context.ts b/packages/plugin-ext/src/plugin/plugin-context.ts
@@ -729,9 +729,7 @@ export function createAPIFactory(
              * event should never fire. This should minimally satisfy vscode built-in extensions that decide
              * to use this proposed API.
              */
-            get onWillCreateEditSessionIdentity(): theia.Event<theia.EditSessionIdentityWillCreateEvent> {
-                return workspaceExt.onWillCreateEditSessionIdentityEvent;
-            }
+            onWillCreateEditSessionIdentity: () => Disposable.create(() => {} ),
         };
 
         const onDidChangeLogLevel = new Emitter<theia.LogLevel>();

diff --git a/packages/plugin-ext/src/plugin/workspace.ts b/packages/plugin-ext/src/plugin/workspace.ts
@@ -60,14 +60,6 @@ export class WorkspaceExtImpl implements WorkspaceExt {
     private didGrantWorkspaceTrustEmitter = new Emitter<void>();
     public readonly onDidGrantWorkspaceTrust: Event<void> = this.didGrantWorkspaceTrustEmitter.event;
 
-    private willCreateEditSessionIdentityEmitter = new Emitter<theia.EditSessionIdentityWillCreateEvent>();
-    /**
-     * @stubbed
-     * This is a stub implementation, lacking a Session Identity server/service, and so the event
-     * should never fire
-     */
-    public readonly onWillCreateEditSessionIdentityEvent: Event<theia.EditSessionIdentityWillCreateEvent> = this.willCreateEditSessionIdentityEmitter.event;
-
     constructor(rpc: RPCProtocol,
         private editorsAndDocuments: EditorsAndDocumentsExtImpl,
         private messageService: MessageRegistryExt) {