Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support InlineValue feature #10028

Closed
Tracked by #9863
tsmaeder opened this issue Sep 1, 2021 · 4 comments · Fixed by #11729
Closed
Tracked by #9863

Support InlineValue feature #10028

tsmaeder opened this issue Sep 1, 2021 · 4 comments · Fixed by #11729
Assignees
@ndoschek
Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 1, 2021

Feature Description:

Support plugins contributing InlineValue objects to the debugger editor, see https://code.visualstudio.com/api/references/vscode-api#InlineValuesProvider

debug-editor-model.ts already has support for inline value decorations, but we would have to call the plugin API to add to or replace the one's we're currently showing.

Depends partially on #10027
@tsmaeder tsmaeder changed the title Support InlineValue featur Support InlineValue feature Sep 1, 2021
@tsmaeder tsmaeder mentioned this issue Sep 1, 2021
Closed
48 tasks
@vince-fugnitto vince-fugnitto added debug issues that related to debug functionality vscode issues related to VSCode compatibility labels Sep 29, 2021
ndoschek added a commit to eclipsesource/vscode that referenced this issue Jun 30, 2022
@ndoschek
Add monaco types for EvaluatableExpression and InlineValue features
2a8c880 
Add types to monaco.languages for 
- EvaluatableExpression feature microsoft#10027 (registerEvaluatableExpressionProvider, EvaluatableExpression, EvaluatableExpressionProvider)
- InlineValue feature microsoft#10028 (registerInlineValuesProvider, InlineValue, InlineValueContext, InlineValueExpression, InlineValuesProvider, InlineValueText, InlineValueVariableLookup)

Part of eclipse-theia/theia#10027 and eclipse-theia/theia#10028

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
ndoschek added a commit to eclipsesource/vscode that referenced this issue Jun 30, 2022
@ndoschek
Add monaco types for EvaluatableExpression and InlineValue features
608b018 
Add types to monaco.languages for 
- EvaluatableExpression feature (registerEvaluatableExpressionProvider, EvaluatableExpression, EvaluatableExpressionProvider)
- InlineValue feature (registerInlineValuesProvider, InlineValue, InlineValueContext, InlineValueExpression, InlineValuesProvider, InlineValueText, InlineValueVariableLookup)

Part of eclipse-theia/theia#10027 and eclipse-theia/theia#10028

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
@ndoschek ndoschek mentioned this issue Jun 30, 2022
Closed
@ndoschek
Copy link
Contributor

ndoschek commented Jun 30, 2022 •
edited
Loading

Awaits uplift of monaco to add the necessary types in the monaco.languages namespace.
Please see PR: theia-ide/vscode#1

@ndoschek
Copy link
Contributor

I'll continue working on this issue

@tsmaeder tsmaeder assigned tsmaeder and ndoschek and unassigned tsmaeder Jul 29, 2022
ndoschek added a commit to eclipsesource/theia that referenced this issue Jul 29, 2022
@ndoschek
eclipse-theia#10028 WIP Support InlineValues
df5434f 
- Implement support for plugins providing inline values

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10028
@ndoschek ndoschek mentioned this issue Aug 3, 2022
Closed
@vince-fugnitto
Copy link
Member

@ndoschek do you have any updates on the issue?

@ndoschek
Copy link
Contributor

Hi @vince-fugnitto, yes I started with that already but ran out of time unfortunately, but I plan to finish it this month.

ndoschek added a commit to eclipsesource/theia that referenced this issue Sep 30, 2022
@ndoschek
eclipse-theia#10028 Support InlineValue feature
d302f5e 
- Implement support for plugins providing inline values

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Resolves eclipse-theia#10028
@ndoschek ndoschek mentioned this issue Sep 30, 2022
Merged
1 task
ndoschek added a commit to eclipsesource/theia that referenced this issue Sep 30, 2022
@ndoschek
eclipse-theia#10028 Support InlineValue feature
952a0f4 
- Implement support for plugins providing inline values

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Resolves eclipse-theia#10028
ndoschek added a commit to eclipsesource/theia that referenced this issue Oct 3, 2022
@ndoschek
eclipse-theia#10028 Support InlineValue feature
b135669 
- Implement support for plugins providing inline values

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Resolves eclipse-theia#10028
JonasHelming pushed a commit that referenced this issue Oct 12, 2022
@ndoschek
#10028 Support InlineValue feature (#11729)
807cf6d 
- Implement support for plugins providing inline values

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Resolves #10028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndoschek ndoschek

Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#10028 Support InlineValue feature eclipsesource/theia
3 participants
@tsmaeder @vince-fugnitto @ndoschek