Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete createStatusBarItem in window namespace from VSCode API #10696

Closed
1 task done
ndoschek opened this issue Feb 1, 2022 · 0 comments · Fixed by #10754
Closed
1 task done

Complete createStatusBarItem in window namespace from VSCode API #10696

ndoschek opened this issue Feb 1, 2022 · 0 comments · Fixed by #10754
Labels
vscode issues related to VSCode compatibility

Comments

@ndoschek
Copy link
Contributor

ndoschek commented Feb 1, 2022 •
edited
Loading

Feature Description:

Add the missing createStatusBarItem function in the window namespace from the VSCode API to the Theia plugin API:

  • createStatusBarItem(id: string, alignment?: StatusBarAlignment, priority?: number)

VSCode API for reference: https://code.visualstudio.com/api/references/vscode-api#window
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Feb 1, 2022
ndoschek added a commit to eclipsesource/theia that referenced this issue Feb 15, 2022
@ndoschek
eclipse-theia#10696 Complete createStatusBarItem in window namespace …
902fd76 
…from VSCode API

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
ndoschek added a commit to eclipsesource/theia that referenced this issue Feb 15, 2022
@ndoschek
eclipse-theia#10696 Complete createStatusBarItem in window namespace …
26ddd3e 
…from VSCode API

- Add createStatusBarItem overload in theia.d.ts to allow an item id as argument
- Extend createStatusBarItem implementation in plugin-context
- Adapt createStatusBarItem in status-bar-message-registry
- Adapat StatusBarItemImpl to accept external ids

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10696
@ndoschek ndoschek mentioned this issue Feb 15, 2022
Merged
1 task
ndoschek added a commit to eclipsesource/theia that referenced this issue Feb 15, 2022
@ndoschek
eclipse-theia#10696 Complete createStatusBarItem in window namespace …
2b0094f 
…from VSCode API

- Add createStatusBarItem overload in theia.d.ts to allow an item id as argument
- Extend createStatusBarItem implementation in plugin-context
- Adapt createStatusBarItem in status-bar-message-registry
- Adapat StatusBarItemImpl to accept external ids

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10696
ndoschek added a commit to eclipsesource/theia that referenced this issue Feb 15, 2022
@ndoschek
eclipse-theia#10696 Complete createStatusBarItem in window namespace …
6954f76 
…from VSCode API

- Add createStatusBarItem overload in theia.d.ts to allow an item id as argument
- Extend createStatusBarItem implementation in plugin-context
- Adapt createStatusBarItem in status-bar-message-registry
- Adapt StatusBarItemImpl to accept external ids

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10696
@ndoschek ndoschek mentioned this issue Feb 25, 2022
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#10696 Complete createStatusBarItem in window namespace from VSCode API eclipsesource/theia
2 participants
@vince-fugnitto @ndoschek