Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theming: set theia-file-icons as the default file icon theme #11020

Closed
Tpuljak opened this issue Apr 13, 2022 · 2 comments · Fixed by #12346
Closed

theming: set theia-file-icons as the default file icon theme #11020

Tpuljak opened this issue Apr 13, 2022 · 2 comments · Fixed by #12346
Labels
proposal feature proposals (potential future features) theming issues related to theming

Comments

@Tpuljak
Copy link
Contributor

Tpuljak commented Apr 13, 2022

Bug Description:

After the last update (1.24) it seems that theia file icons are not set by default. No file icons are displayed by default.

Steps to Reproduce:

  1. Update theia to 1.24
  2. Run

Additional Information

Before the update, theia file icons were default and now this preference has to be applied to make them default:

          "workbench.iconTheme": "theia-file-icons"
  • Operating System: MacOS
  • Theia Version: 1.24.0
@vince-fugnitto
Copy link
Member

vince-fugnitto commented Apr 13, 2022 •
edited
Loading

@Tpuljak thank you for the discussion, but it is not a bug, it was a decision made a while ago to use 'none' as a theme so that applications would be more inclined to set their own. The only thing that was changed in 1.24.0 was to fix a bug on startup where the default was not being applied properly (which is why you see the 'none' apply).

Note: we are discussing updating to theia-file-icons as the default but I still believe applications should set their own.

@Tpuljak
Copy link
Contributor Author

Tpuljak commented Apr 13, 2022

Thanks for the reply @vince-fugnitto.
If I'm a factor in the decision, I vote to have theia icons defaulted 😅.

Especially because newer developers might struggle to find how to change the default.

@vince-fugnitto vince-fugnitto added the proposal feature proposals (potential future features) label Apr 13, 2022
@vince-fugnitto vince-fugnitto changed the title Theia file icons are no longer defaulted theming: set theia-file-icons as the default file icon theme Apr 13, 2022
@vince-fugnitto vince-fugnitto added the theming issues related to theming label Apr 13, 2022
@msujew msujew mentioned this issue Apr 14, 2022
Closed
1 task
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 23, 2023
@FernandoAscencio
theming: default set to theia-file-icons
d5ff038 
Closes eclipse-theia#11020
Linked to eclipse-theia#11028

Signed-Off-By: FernandoAscencio <fernando.ascencio,cama@ericsson.com>
@FernandoAscencio FernandoAscencio mentioned this issue Mar 23, 2023
Merged
1 task
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 23, 2023
@FernandoAscencio @msujew
theming: default set to theia-file-icons
8af06ea 
Closes eclipse-theia#11020
Linked to eclipse-theia#11028

Signed-Off-By: FernandoAscencio <fernando.ascencio,cama@ericsson.com>
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal feature proposals (potential future features) theming issues related to theming
Projects
None yet
Milestone
No milestone
2 participants
@Tpuljak @vince-fugnitto