Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Theia development image #1153

Closed
marcdumais-work opened this issue Jan 29, 2018 · 5 comments
Closed

[docker] Theia development image #1153

marcdumais-work opened this issue Jan 29, 2018 · 5 comments
Labels
design issues related to design

Comments

@marcdumais-work
Copy link
Contributor

This discussion was started in this PR .

For convenience, here are screen captures:

image
image

@marcdumais-work
Copy link
Contributor Author

@svenefftinge So IIUC the plan would be, when we eventually move non-core extension each to their own repo, they could then have a (single) more specialized dev image, containing specific dependencies (e.g. JDK for the Java extension, clangd for the C/C++ ext, ..). That sounds good to me.

What shall we do in the meantime? Would it be ok to temporarily add the dependencies in the dev image here, when needed (JDK)?

@marcdumais-work
Copy link
Contributor Author

@akosyakov about running the Electron app in docker: this could be an enabler: #174 . We plan to work on that issue relatively soon.

@svenefftinge
Copy link
Contributor

What shall we do in the meantime? Would it be ok to temporarily add the dependencies in the dev image here, when needed (JDK)?

Yes

@akosyakov
Copy link
Member

Could we at least move dev docker files to another folder from the browser example? Like dockerfiles under the root?

@vince-fugnitto
Copy link
Member

The issue is now outdated since the example Dockerfile has recently been removed from the repository since it was unmaintained/unused: #6585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issues related to design
Projects
None yet
Development

No branches or pull requests

4 participants