Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] remove example dockerfile #6585

Merged
merged 1 commit into from
Nov 20, 2019
Merged

[docker] remove example dockerfile #6585

merged 1 commit into from
Nov 20, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #6474
Fixes #6191

  • removed the outdated and un-maintained example dockerfile from the repo.
  • since the dockerfile is not maintained, and play-with-docker no longer works without actually signing in, the dockerfile just caused issues and users and adopters should instead be re-directed to theia-apps in order to view concrete and thorough examples of docker images.
  • the effort of maintaining the dockerfile within the repo is not worth the odd use case of developers testing their changes through it.

Motivation:

How to test

  • verify that CI successfully passes

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

Fixes #6474
Fixes #6191

- removed the outdated and un-maintained example dockerfile from the repo.
- since the dockerfile is not maintained, and `play-with-docker` no longer
works without actually signing in, the dockerfile just caused issues and
users and adopters should instead be re-directed to `theia-apps` in order
to view concrete and thorough examples of docker images.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the docker issues related to docker label Nov 19, 2019
@vince-fugnitto vince-fugnitto self-assigned this Nov 19, 2019
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vince

@vince-fugnitto vince-fugnitto merged commit 2c6df90 into master Nov 20, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6474 branch November 20, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker issues related to docker
Projects
None yet
4 participants