Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace service does not handle updates on network drives #12132

Open
zakr600 opened this issue Feb 1, 2023 · 3 comments
Open

Workspace service does not handle updates on network drives #12132

zakr600 opened this issue Feb 1, 2023 · 3 comments
Labels
help wanted issues meant to be picked up, require help workspace issues related to the workspace

Comments

@zakr600
Copy link

zakr600 commented Feb 1, 2023

Bug Description:

If I create a multiroot workspace on a network drive then Workspace service couldn't handle workspace root updates.

if (this._workspace && this._workspace.isFile && event.contains(this._workspace.resource)) {

"event.contains(this._workspace.resource)" Condition is always false because this._workspace.resource == "/u:/my-workspace" and event.changes[0].resource == "/userbackup/admin/my-workspace/roots.json"
But u:/ and /userbackup/admin are the same drives. Nevertheless, "event.contains" check returns false

Steps to Reproduce:

  1. Create multiroot workspace on a network drive where
  2. Open ide on this workspace
  3. Edit the file containing workspace roots
  4. Workspace service couldn't handle file update

Additional Information

  • Operating System:
    Windows 10
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help workspace issues related to the workspace labels Feb 6, 2023
@tsmaeder
Copy link
Contributor

@zakr600 it would be interesting to know how you set up your system so that u:\ and /userbackup/admin/ point to the same place. Windows, I assume?

@hannescmarits
Copy link

#12771
At least this works in VS Code. No idea if this works in Code OSS as well.

@msujew
Copy link
Member

msujew commented Aug 7, 2023

@hannescmarits Can you test whether #12784 fixes the behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issues meant to be picked up, require help workspace issues related to the workspace
Projects
None yet
Development

No branches or pull requests

5 participants