Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor should react on file changes done in a different editor, i. e. notepad #12771

Closed
hannescmarits opened this issue Jul 27, 2023 · 6 comments
Labels
file-watchers issues related to filesystem watchers - nsfw 🤔 needs more info issues that require more info from the author

Comments

@hannescmarits
Copy link

If a file is open in the editor of theia and the file is changed and saved in an other editor, for example VS Code, than the changes should be displayed also in the editor of theia

At least with the Eclipse Blueprint Version 1.39.0 (Beta) this did not work.

Feature Description:

Just react on file changes done in other editors.

@hannescmarits hannescmarits changed the title Editor should react on file changes done in a different editor Editor should react on file changes done in a different editor, i. e. notepad Jul 27, 2023
@vince-fugnitto vince-fugnitto added the 🤔 needs more info issues that require more info from the author label Jul 27, 2023
@vince-fugnitto
Copy link
Member

@hannescmarits thank you for reporting the issue, as far as I am aware this works as expected (tested on both blueprint and from sources on Linux). Do you have any additional information about your system? Are you running out of inotify watchers?

@hannescmarits
Copy link
Author

hannescmarits commented Jul 28, 2023

@vince-fugnitto
As mentioned i use the Blueprint Version 1.39.9 (Beta) under Windows 11.
It doesn't matter if the file is on my pc or on a server.
It get no update information, and the file gets not updated.
I am not sure how to check if the system runs out of inotify watchers. Can you please clarify how i can test this.
Thanks in advance

@vladarama
Copy link
Contributor

@hannescmarits
I just tested on my Windows machine, using Blueprint 1.39.0 and I cannot reproduce this issue, seems to work fine on my end.

Demo:
editor reacting file change

@vince-fugnitto
Copy link
Member

@hannescmarits I had a colleague test on Windows (repo and blueprint) (#12771 (comment)) and it worked as intended.

I'm not exactly sure what is happening in your case, does it work for smaller workspaces, are you certain you are modifying the same file and that it is being saved? If you would like to debug you can determine if you're properly receiving file watching events from @theia/filesystem.

@vince-fugnitto vince-fugnitto added the file-watchers issues related to filesystem watchers - nsfw label Jul 28, 2023
@hannescmarits
Copy link
Author

hannescmarits commented Jul 28, 2023

@vince-fugnitto
It works fine.
Maybe i really used two days wrong files. BAMM.

Okay testing it again.
Yes it works fine if the file is on my local machine.
But if the file is on a server (access via VPN) than no changes are recognized.
Thank you.

@vince-fugnitto vince-fugnitto closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
@msujew
Copy link
Member

msujew commented Jul 28, 2023

@hannescmarits Theia not being able to register updates on networks drives is a known issue, see #12132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-watchers issues related to filesystem watchers - nsfw 🤔 needs more info issues that require more info from the author
Projects
None yet
Development

No branches or pull requests

4 participants