Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvements in the Windows building documentation #1614

Closed
epatpol opened this issue Mar 29, 2018 · 1 comment · Fixed by #6893
Closed

Possible improvements in the Windows building documentation #1614

epatpol opened this issue Mar 29, 2018 · 1 comment · Fixed by #6893
Assignees
Labels
documentation issues related to documentation enhancement issues that are enhancements to current functionality - nice to haves OS/Windows issues related to the Windows OS

Comments

@epatpol
Copy link
Contributor

epatpol commented Mar 29, 2018

I just tried to build Theia in a windows 10 developer vbox image and following the steps here to build it several steps failed.

choco install yarn --version 1.2.1 -y Failed because we already installed a later version (1.5.0) at the time of this writing beforehand. But I also wondered if you couldn't install this one directly without doing that choco install yarn command before.

Also I noticed that we use both cmd/Powershell/Git bash just to build and run theia according to the docs. Maybe there's a good reason for using git bash but If possible I would like to avoid having that dependency in the documentation. It makes it so that new developers have to possibly install another program before running it. @kittaakos I know you tested a lof of stuff of Windows, so probably there's a valid reason for this (I just tried yarn in powershell and it didn't work and resulted in weird errors...).

@epatpol epatpol added enhancement issues that are enhancements to current functionality - nice to haves OS/Windows issues related to the Windows OS documentation issues related to documentation labels Mar 29, 2018
@kittaakos
Copy link
Contributor

to build it several steps failed.

That is unfortunate. Documentation could get quickly out of sync.

choco install yarn --version 1.2.1 -y Failed because we already installed a later version (1.5.0)

I do not understand this implication, but it could happen, we need to adjust the version numbers. I do not know the default yarn version on the AppVeyor image we are currently using, but I am positive, we still have yarn 1.2.1for both the Linux and the OS X builds. I think I still use 1.2.1 on my local Windows image too. Worked so far.

we use both cmd/Powershell/Git bash just to build and run theia according to the docs

Correct.

Maybe there's a good reason for using git bash

There is. My Windows knowledge is pretty limited, but Windows does not come with Git by default. The out of the box solution is the Git installer that comes with Git Bash, right? By the way, I usually use either Cygwin or Git Bash on Windows.

I would like to avoid having that dependency in the documentation

If you have a better approach, please, be my guest, adjust it; I could help verifying things on Windows. Our goal is to help Windows users start using Theia.

It makes it so that new developers have to possibly install another program before running it

Ohh, they have to do that anyway; MS Build Tools, Python...

it didn't work and resulted in weird errors...

I have to see the full console log from the very beginning (installing Python and so on) to the last failing yarn command to be able to see what went wrong.

adamretter added a commit to adamretter/theia that referenced this issue Aug 18, 2018
… be done from cmd.exe (don't need different shells)

Closes eclipse-theia#1614
See also eclipse-theia#2009
adamretter added a commit to adamretter/theia that referenced this issue Aug 18, 2018
… be done from cmd.exe (don't need different shells)

Closes eclipse-theia#1614
See also eclipse-theia#2009
adamretter added a commit to adamretter/theia that referenced this issue Aug 31, 2018
… be done from cmd.exe (don't need different shells)

Closes eclipse-theia#1614
See also eclipse-theia#2009
adamretter added a commit to adamretter/theia that referenced this issue Aug 31, 2018
… be done from cmd.exe (don't need different shells)

Closes eclipse-theia#1614
See also eclipse-theia#2009
adamretter added a commit to adamretter/theia that referenced this issue Nov 1, 2018
… be done from cmd.exe (don't need different shells)

Closes eclipse-theia#1614
See also eclipse-theia#2009
adamretter added a commit to adamretter/theia that referenced this issue Nov 1, 2018
… be done from cmd.exe (don't need different shells)

Closes eclipse-theia#1614
See also eclipse-theia#2009

Signed-off-by: Adam Retter <adam.retter@googlemail.com>
@kittaakos kittaakos self-assigned this Jan 14, 2020
kittaakos pushed a commit that referenced this issue Jan 16, 2020
Got rid of `choco` and simplified the steps with `scoop`.

The steps now include headless commands for installing the followings:
 - `nvm`,
 - Node.js,
 - `yarn`, and optionally
 - `git`.

Closes #1614

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Jan 19, 2020
Got rid of `choco` and simplified the steps with `scoop`.

The steps now include headless commands for installing the followings:
 - `nvm`,
 - Node.js,
 - `yarn`, and optionally
 - `git`.

Closes #1614

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
Got rid of `choco` and simplified the steps with `scoop`.

The steps now include headless commands for installing the followings:
 - `nvm`,
 - Node.js,
 - `yarn`, and optionally
 - `git`.

Closes eclipse-theia#1614

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation enhancement issues that are enhancements to current functionality - nice to haves OS/Windows issues related to the Windows OS
Projects
None yet
2 participants