Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should disable closing preferences editors from middle mouse click #2639

Closed
vince-fugnitto opened this issue Aug 21, 2018 · 0 comments · Fixed by #6198
Closed

Should disable closing preferences editors from middle mouse click #2639

vince-fugnitto opened this issue Aug 21, 2018 · 0 comments · Fixed by #6198
Labels
bug bugs found in the application preferences issues related to preferences

Comments

@vince-fugnitto
Copy link
Member

Currently, we correctly remove the possibility of closing Preferences editors (User Preferences, Workspace Preferences) with 🗙 (Close) and Right Click > Close, but we do not handle the case of closing using the middle mouse click.

preferences-bug
@vince-fugnitto vince-fugnitto added bug bugs found in the application preferences issues related to preferences labels Aug 21, 2018
@vince-fugnitto vince-fugnitto changed the title Should disable closing preferences tabs from middle mouse click Should disable closing preferences editors from middle mouse click Aug 21, 2018
vince-fugnitto added a commit that referenced this issue Sep 16, 2019
@vince-fugnitto
Prevent closing preference editor with the middle mouse click
404e312 
Fixes #2639

- prevent closing preference editors using the middle mouse click by
setting the `title.closable` to `false`.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Sep 16, 2019
Merged
1 task
elaihau pushed a commit that referenced this issue Sep 18, 2019
@vince-fugnitto @elaihau
Prevent closing preference editor with the middle mouse click
d306a29 
Fixes #2639

- prevent closing preference editors using the middle mouse click by
setting the `title.closable` to `false`.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@vince-fugnitto @akosyakov
Prevent closing preference editor with the middle mouse click
2043ab4 
Fixes eclipse-theia#2639

- prevent closing preference editors using the middle mouse click by
setting the `title.closable` to `false`.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application preferences issues related to preferences
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[preferences] prevent closing preference editor with the middle mouse click eclipse-theia/theia
1 participant
@vince-fugnitto