Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert NPM version #309

Closed
kittaakos opened this issue Jul 19, 2017 · 10 comments
Closed

Assert NPM version #309

kittaakos opened this issue Jul 19, 2017 · 10 comments
Assignees
Milestone

Comments

@kittaakos
Copy link
Contributor

The script obviously contains an incorrect path for the examples.

If I start the script with the correct path, it complains about the missing start script:

git clone https://github.com/theia-ide/theia \
&& cd theia \
&& npm install --unsafe-perm\
&& cd examples/browser \
&& npm run start
@akosyakov akosyakov self-assigned this Jul 19, 2017
akosyakov added a commit that referenced this issue Jul 19, 2017
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member

@kittaakos could you try with #310?

@kittaakos
Copy link
Contributor Author

Sure.

@kittaakos
Copy link
Contributor Author

It is still broken. Please reference attached log.

@akosyakov
Copy link
Member

Please try to use npm@4, it seems that you are using npm@3.

@kittaakos
Copy link
Contributor Author

Although it is still running, it looks better. I keep you posted.

Can we assert the npm version: https://www.npmjs.com/package/assert-npm-version

@kittaakos
Copy link
Contributor Author

Great, it works with your changes.

@akosyakov
Copy link
Member

Yes, asserting would be great, npm suggests using engines for it: https://docs.npmjs.com/files/package.json#engines

@kittaakos
Copy link
Contributor Author

I would be happy with any libraries if it works as expected.

@akosyakov akosyakov changed the title TL;DR scripts are broken for the examples Assert npm version Jul 19, 2017
@akosyakov akosyakov changed the title Assert npm version Assert NPM version Jul 19, 2017
akosyakov added a commit that referenced this issue Jul 20, 2017
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member

it is obsolete with yarn

@kittaakos
Copy link
Contributor Author

@akosyakov, what about #179?

lmcgupe pushed a commit to lmcgupe/theia that referenced this issue Jul 21, 2017
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@svenefftinge svenefftinge added this to the Theia 1.0 BETA milestone Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants