Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Right click on editor tab scrollbar shows native menu #4007

Open
geropl opened this issue Jan 10, 2019 · 2 comments
Open

[ui] Right click on editor tab scrollbar shows native menu #4007

geropl opened this issue Jan 10, 2019 · 2 comments
Labels
ui/ux issues related to user interface / user experience

Comments

@geropl
Copy link
Contributor

geropl commented Jan 10, 2019

When (accidentally) right-clicking the editor tab bars scrollbar the browser native context menu is shown. As a user I would expect that to be suppressed because it breaks the Theia experience:
out

(Happens to me very often when trying to "Close all" editor tabs.

@geropl geropl added ui/ux issues related to user interface / user experience browser/firefox issues related to the firefox browser labels Jan 10, 2019
@AlexTugarev AlexTugarev removed the browser/firefox issues related to the firefox browser label Mar 22, 2019
@AlexTugarev AlexTugarev changed the title [ui][firefox] Right click on editor tab scrollbar shows native menu [ui] Right click on editor tab scrollbar shows native menu Mar 22, 2019
@AlexTugarev
Copy link
Contributor

Chrome on Mac: same behavior

Screen Shot 2019-03-22 at 10 01 43

@jankeromnes
Copy link
Member

jankeromnes commented Mar 22, 2019

I agree, when you have many files open, that horizontal scroll bar is annoying (it takes so much space on Firefox Nightly on Mac).

Then again, I sometimes forget about some open files, because there is no other indicator that I have too many tabs open and they're overflowing.

VS Code also has just the horizontal scrollbar, but it's super thin on Mac so it's pretty easy to right click on the tab handles (and it's actually pretty hard to try and "accidentally" click the scrollbar).

TL;DR moving the scrollbar down and making it much thinner would help a lot.

vince-fugnitto added a commit that referenced this issue Oct 21, 2019
Fixes #4007

Add additional handling to handle `contexmenu` events
which would display the browsers default contextmenu
which breaks up the user experience. The default browser
`contextmenu` is thus disabled.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants