Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align quick task palette look with VS Code #4770

Closed
akosyakov opened this issue Apr 1, 2019 · 0 comments · Fixed by #4917
Closed

Align quick task palette look with VS Code #4770

akosyakov opened this issue Apr 1, 2019 · 0 comments · Fixed by #4917
Assignees
@vince-fugnitto
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Apr 1, 2019 •
edited
Loading

  • Recently used, configured and detected tasks should be visually separated by a line.
  • Quick task description should be aligned with VS Code. One should investigate how it works there. On the first glance it is only present if there are more than one root, otherwise it is obvious and only clutter the palette.
  • Align configure action icon to right border. For some reasons there are more space for Theia.

VS Code:
Screen Shot 2019-03-27 at 14 32 38

Theia:
Screen Shot 2019-04-01 at 12 14 26

cc @elaihau @RomanNikitenko
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system vscode issues related to VSCode compatibility labels Apr 1, 2019
@akosyakov akosyakov mentioned this issue Apr 1, 2019
Merged
@vince-fugnitto vince-fugnitto self-assigned this Apr 10, 2019
@elaihau elaihau mentioned this issue Apr 10, 2019
Merged
vince-fugnitto added a commit that referenced this issue Apr 15, 2019
@vince-fugnitto
Align tasks quick-open
c561d60 
Fixes #4770

- aligned the `tasks` quick-open to display borders between categories (recently opened, configured, and provided tasks).
- aligned the `tasks` quick-open to only display a description (uri) when running in multi-root.
- fixed issue regarding right spacing in the quick-open which did not display the border correctly nor the action providers.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Apr 15, 2019
Merged
vince-fugnitto added a commit that referenced this issue Apr 16, 2019
@vince-fugnitto
Align tasks quick-open
3f359da 
Fixes #4770

- aligned the `tasks` quick-open to display borders between categories (recently opened, configured, and provided tasks).
- aligned the `tasks` quick-open to only display a description (uri) when running in multi-root.
- fixed issue regarding right spacing in the quick-open which did not display the border correctly nor the action providers.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Apr 16, 2019
@vince-fugnitto
Align tasks quick-open
3af6e36 
Fixes #4770

- aligned the `tasks` quick-open to display borders between categories (recently opened, configured, and provided tasks).
- aligned the `tasks` quick-open to only display a description (uri) when running in multi-root.
- fixed issue regarding right spacing in the quick-open which did not display the border correctly nor the action providers.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
DoroNahari pushed a commit to DoroNahari/theia that referenced this issue Apr 29, 2019
@vince-fugnitto
Align tasks quick-open
1f8f934 
Fixes eclipse-theia#4770

- aligned the `tasks` quick-open to display borders between categories (recently opened, configured, and provided tasks).
- aligned the `tasks` quick-open to only display a description (uri) when running in multi-root.
- fixed issue regarding right spacing in the quick-open which did not display the border correctly nor the action providers.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Doron Nahari doron.nahari@sap.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vince-fugnitto vince-fugnitto

Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tasks] align tasks quick-open with vscode eclipse-theia/theia
2 participants
@akosyakov @vince-fugnitto