Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle plugins with no activate function #4850

Closed
tsmaeder opened this issue Apr 10, 2019 · 0 comments
Closed

Handle plugins with no activate function #4850

tsmaeder opened this issue Apr 10, 2019 · 0 comments
Assignees
@AndrienkoAleksandr
Labels
bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Apr 10, 2019 •
edited by tolusha
Loading

Some VS Code extensions don't see to export and activate function, for example the PHP debug.
While this is correct (see https://code.visualstudio.com/api/references/activation-events#Start-up), we should probably still load those plugins, becuase VS Code does the same.
I see this as a safe change, since we can just assume an empty "activate" function when none is present.

https://marketplace.visualstudio.com/items?itemName=felixfbecker.php-debug
This was referenced Apr 10, 2019
Closed
Closed
@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Apr 10, 2019
@evidolob evidolob added the plug-in system issues related to the plug-in system label Apr 10, 2019
@evidolob evidolob mentioned this issue Apr 11, 2019
Closed
50 tasks
@evidolob evidolob added the Team: Che-Editors issues regarding the che-editors team label Apr 11, 2019
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Apr 11, 2019
@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrienkoAleksandr AndrienkoAleksandr

Labels
bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@evidolob @akosyakov @AndrienkoAleksandr @tsmaeder