Fix work extensions with no activation function #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
requested review from
benoitf,
evidolob,
akosyakov and
akurinnoy
|
@tsmaeder tested with mock debugger: https://github.com/AndrienkoAleksandr/vscode-mock-debug |
|
FYI eclipse eca check is not green |
benoitf
approved these changes
Apr 17, 2019
|
Hmm... after merge with master and this one commit a388fc5 my pr doesn't work any more. I will take a look...
Thanks, I will fix it. |
akosyakov
reviewed
Apr 18, 2019
| @@ -67,7 +67,7 @@ export class HostedPluginSupport { | |||
| } | |||
|
|
|||
| runPlugin(plugin: PluginModel): void { | |||
| if (plugin.entryPoint.backend) { | |||
| if (!plugin.entryPoint.frontend) { | |||
There was a problem hiding this comment.
Can plugin have frontend and backend entry points?
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
force-pushed
the
fixWorkExtensionsWithNoActivationFunction
branch
from
6fe6b49 to
19ffb9d
Compare
|
I'm Sorry, guys my alert was wrong:
I retested PR works. |
evidolob
approved these changes
Apr 18, 2019
AndrienkoAleksandr
deleted the
fixWorkExtensionsWithNoActivationFunction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issue:
#4850
Description
We count's all vscode extensions like "backend theia plugins": https://github.com/theia-ide/theia/blob/master/packages/plugin-ext-vscode/src/node/scanner-vscode.ts#L42
So let's launch all not frontend plugins like backend plugins. And In case if extension has no activation function(and plugin path in this case was not initialized) allow to initialize this extension, but don't allow load extension script and don't allow start extension script(because no main script and activation methods).
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com