Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git Add Signed-off-by error if not set email and username #4908

Closed
502647092 opened this issue Apr 15, 2019 · 0 comments · Fixed by #6222
Closed

git Add Signed-off-by error if not set email and username #4908

502647092 opened this issue Apr 15, 2019 · 0 comments · Fixed by #6222
Labels
bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help

Comments

@502647092
Copy link
Contributor

Description

image

image

Reproduction Steps

modify some file
on git page click Add Signed-off-by bottom

OS and Theia version:
Diagnostics:
@akosyakov akosyakov added bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help labels Apr 15, 2019
vince-fugnitto added a commit that referenced this issue Sep 19, 2019
@vince-fugnitto
Handle attempting to sign-off without configs
c58d495 
Fixes #4908

Handle the toolbar action to add a sign-off when the
user does not have their `user.name` and `user.email` configured.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Sep 19, 2019
Merged
1 task
vince-fugnitto added a commit that referenced this issue Sep 23, 2019
@vince-fugnitto
Handle attempting to sign-off without configs
f949db1 
Fixes #4908

Handle the toolbar action to add a sign-off when the
user does not have their `user.name` and `user.email` configured.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@vince-fugnitto @akosyakov
Handle attempting to sign-off without configs
9e820dd 
Fixes eclipse-theia#4908

Handle the toolbar action to add a sign-off when the
user does not have their `user.name` and `user.email` configured.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[git] handle attempting to sign-off without configs eclipse-theia/theia
2 participants
@akosyakov @502647092