Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tasks] unable to configure tasks when in a multi-root workspace #4919

Closed
vince-fugnitto opened this issue Apr 15, 2019 · 1 comment · Fixed by #5777
Closed

[tasks] unable to configure tasks when in a multi-root workspace #4919

vince-fugnitto opened this issue Apr 15, 2019 · 1 comment · Fixed by #5777
Assignees
@elaihau
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@vince-fugnitto
Copy link
Member

Description
Unable to configure tasks when in a multi-root workspace.

task-service.ts:15 Uncaught (in promise) Error: Request 'createFile' failed
    at Proxy.<anonymous> (proxy-factory.ts:232)
    at TaskConfigurations.<anonymous> (task-configurations.ts:267)
    at step (task-configurations.ts:15)
    at Object.next (task-configurations.ts:15)
    at fulfilled (task-configurations.ts:15)

Reproduction Steps

  1. Open a multi-root workspace.
  2. Perform the command Run Task... and attempt to configure a task (small cog icon).
  3. Notice that nothing occurs, and an uncaught error is thrown.
@vince-fugnitto vince-fugnitto added bug bugs found in the application tasks issues related to the task system labels Apr 15, 2019
This was referenced Jun 17, 2019
Merged
Closed
@elaihau elaihau self-assigned this Jul 16, 2019
@elaihau
Copy link
Contributor

elaihau commented Jul 16, 2019

shouldn't be hard. I will take care of it together with other changes.

elaihau pushed a commit that referenced this issue Jul 23, 2019
edit the right task.json when clicking "configure task" in multi-root…
fe431f2 
… workspace

- fixed #4919

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
This was referenced Jul 23, 2019
Closed
Merged
elaihau pushed a commit that referenced this issue Jul 24, 2019
align "configure task" and "task quick open" with vs code
396b329 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Jul 24, 2019
align "configure task" and "task quick open" with vs code
baab4d6 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Jul 27, 2019
align "configure task" and "task quick open" with vs code
14b89f3 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than the ones used in the task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Jul 28, 2019
align "configure task" and "task quick open" with vs code
29dbe89 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than the ones used in the task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Jul 28, 2019
align "configure task" and "task quick open" with vs code
0fb0b45 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than `type`, and those that are used to define the in its task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 1, 2019
align "configure task" and "task quick open" with vs code
2fe7262 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than `type`, and those that are used to define the in its task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 1, 2019
@elaihau
align "configure task" and "task quick open" with vs code
e0d38ee 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than `type`, and those that are used to define the in its task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Milestone
No milestone
2 participants
@elaihau @vince-fugnitto