Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recompute editors on mime associations change #5017

Closed
tolusha opened this issue Apr 26, 2019 · 0 comments · Fixed by #7805
Closed

Recompute editors on mime associations change #5017

tolusha opened this issue Apr 26, 2019 · 0 comments · Fixed by #7805
Assignees
@akosyakov
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves filesystem issues related to the filesystem

Comments

@tolusha
Copy link
Contributor

tolusha commented Apr 26, 2019

Description

Once a new mimetype association is changed [1] we have to recompute opened editors to reflect correct language like in VS Code [2]

[1] https://github.com/theia-ide/theia/blob/master/packages/filesystem/src/browser/filesystem-frontend-contribution.ts#L161
[2] https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/mode/common/workbenchModeService.ts#L185

Reference issue

#4581
@tolusha tolusha added the enhancement issues that are enhancements to current functionality - nice to haves label Apr 26, 2019
@akosyakov akosyakov added editor issues related to the editor filesystem issues related to the filesystem labels May 13, 2020
@akosyakov akosyakov mentioned this issue May 13, 2020
Closed
akosyakov added a commit that referenced this issue May 13, 2020
@akosyakov
fix #5017: detect languages on mime associations change
163aa19 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue May 13, 2020
Merged
1 task
@akosyakov akosyakov self-assigned this May 13, 2020
akosyakov added a commit that referenced this issue May 14, 2020
@akosyakov
fix #5017: detect languages on mime associations change
55af692 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
RomanNikitenko pushed a commit that referenced this issue May 14, 2020
@akosyakov @RomanNikitenko
fix #5017: detect languages on mime associations change
accc27c 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves filesystem issues related to the filesystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve handling of mime associations eclipse-theia/theia
2 participants
@tolusha @akosyakov