Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automatic keyboard layout detection #5042

Closed
spoenemann opened this issue Apr 30, 2019 · 0 comments · Fixed by #5063
Closed

Improve automatic keyboard layout detection #5042

spoenemann opened this issue Apr 30, 2019 · 0 comments · Fixed by #5063
Assignees
Labels
keybindings issues related to keybindings

Comments

@spoenemann
Copy link
Contributor

Keyboard layout detection works quite well in Chrome since it supports the keyboard-map API. For browsers that don't support it, we currently fall back to guessing based on the navigator.language property, which is very error-prone because many developers (like me) use English as OS / browser language, but a non-US keyboard layout. #4879 suggests adding a UI to manually select a keyboard layout. We should have that UI, but in addition we should try to improve the automatic detection.

A possible approach for this could be to "listen" to the user's keyboard events and evaluate their KeyCodes against the list of known keyboard layouts.

@spoenemann spoenemann added the keybindings issues related to keybindings label Apr 30, 2019
@spoenemann spoenemann self-assigned this Apr 30, 2019
spoenemann added a commit that referenced this issue May 2, 2019
Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
spoenemann added a commit that referenced this issue May 3, 2019
Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
AlexTugarev pushed a commit that referenced this issue May 3, 2019
Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant