Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin-Api] Apply 'comment.createCommentController' function #5076

Closed
vinokurig opened this issue May 6, 2019 · 3 comments
Closed

[Plugin-Api] Apply 'comment.createCommentController' function #5076

vinokurig opened this issue May 6, 2019 · 3 comments
Assignees
@vinokurig
Labels
monaco issues related to monaco plug-in system issues related to the plug-in system

Comments

@vinokurig
Copy link
Contributor

Description

Related function in VsCode: https://github.com/Microsoft/vscode/blob/da3c97f3668393ebfcb9f8208d7616018d6d1859/src/vs/vscode.d.ts#L9207-L9216

Is needed for eclipse-che/che#11867
@vinokurig vinokurig self-assigned this May 6, 2019
@vparfonov vparfonov mentioned this issue May 6, 2019
Closed
10 tasks
@vinokurig vinokurig added the plug-in system issues related to the plug-in system label May 6, 2019
@akosyakov akosyakov added the monaco issues related to monaco label May 7, 2019
@akosyakov
Copy link
Member

akosyakov commented May 7, 2019 •
edited
Loading

We should check whether it is possible to create Monaco distribution including source code implementing comments support without pulling too much dependencies. It can save time reimplementing it ourself with similar to VS Code exp. Plus catching up with Monaco and LSP makes sense generally. We are already lagging behind for one year.

cc @svenefftinge

@vinokurig vinokurig mentioned this issue May 11, 2019
Merged
@vparfonov vparfonov mentioned this issue May 15, 2019
Closed
15 tasks
@akosyakov
Copy link
Member

Regarding #5076 (comment) unfortunately this code belongs completely to the workbench layer of VS Code and pulls a lot of dependencies. We will have to implement our own UI for it. It is quite involving task.

@vinokurig
Copy link
Contributor Author

Is fixed by #8870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
monaco issues related to monaco plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosyakov @vinokurig