-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(VS Code Extensions) window.withProgress isCancellable is not respected #5578
Labels
bug
bugs found in the application
help wanted
issues meant to be picked up, require help
notifications
issues related to notifications
plug-in system
issues related to the plug-in system
vscode
issues related to VSCode compatibility
Comments
tetchel
changed the title
window.withProgress isCancellable is not respected
(VS Code Extensions) window.withProgress isCancellable is not respected
Jun 25, 2019
vince-fugnitto
added
bug
bugs found in the application
plug-in system
issues related to the plug-in system
vscode
issues related to VSCode compatibility
labels
Jun 25, 2019
@akosyakov, is this any way I can get this prioritized, it's been silent for 3 months This is a pretty bad one because there is no workaround for me, and users get confused when the action they cancelled continues to run. |
AlexTugarev
added a commit
that referenced
this issue
Oct 10, 2019
Fixes #5578 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
1 task
AlexTugarev
added a commit
that referenced
this issue
Oct 11, 2019
also cleaned up unused `NotificationMain.$startProgress` options. Fixes #5578 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev
added a commit
that referenced
this issue
Oct 11, 2019
also cleaned up unused `NotificationMain.$startProgress` options. Fixes #5578 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Now that's service! ❤️ |
Thanks for reporting, btw. |
akosyakov
pushed a commit
to akosyakov/theia
that referenced
this issue
Feb 24, 2020
also cleaned up unused `NotificationMain.$startProgress` options. Fixes eclipse-theia#5578 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
bugs found in the application
help wanted
issues meant to be picked up, require help
notifications
issues related to notifications
plug-in system
issues related to the plug-in system
vscode
issues related to VSCode compatibility
Description
ProgressOptions.isCancellable
is not respected by Theia. The "Cancel" button is always present.https://code.visualstudio.com/api/references/vscode-api#ProgressOptions
Reproduction Steps
window.withProgress
setting theisCancellable
ProgressOptions
tofalse
.In VS Code, the Cancel button is not shown if
cancellable: false
is given. In Theia, the Cancel button is always shown.OS and Theia version:
macOS mojave, theia version
next
Diagnostics:
The text was updated successfully, but these errors were encountered: