Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(VS Code Extensions) window.withProgress isCancellable is not respected #5578

Closed
tetchel opened this issue Jun 25, 2019 · 3 comments · Fixed by #6365
Closed

(VS Code Extensions) window.withProgress isCancellable is not respected #5578

tetchel opened this issue Jun 25, 2019 · 3 comments · Fixed by #6365
Assignees
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help notifications issues related to notifications plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@tetchel
Copy link
Contributor

tetchel commented Jun 25, 2019

Description

ProgressOptions.isCancellable is not respected by Theia. The "Cancel" button is always present.

https://code.visualstudio.com/api/references/vscode-api#ProgressOptions

Reproduction Steps

  • call window.withProgress setting the isCancellable ProgressOptions to false.
        const validateResponse = await vscode.window.withProgress({
            title: `Processing ${pathToBind}...`,
            location: vscode.ProgressLocation.Notification,
            cancellable: false,
        }, () => {
           // ... your callback
        });

In VS Code, the Cancel button is not shown if cancellable: false is given. In Theia, the Cancel button is always shown.

OS and Theia version:
macOS mojave, theia version next

Diagnostics:

@tetchel tetchel changed the title window.withProgress isCancellable is not respected (VS Code Extensions) window.withProgress isCancellable is not respected Jun 25, 2019
@vince-fugnitto vince-fugnitto added bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Jun 25, 2019
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jul 1, 2019
@tetchel
Copy link
Contributor Author

tetchel commented Oct 10, 2019

@akosyakov, is this any way I can get this prioritized, it's been silent for 3 months

This is a pretty bad one because there is no workaround for me, and users get confused when the action they cancelled continues to run.

@AlexTugarev AlexTugarev self-assigned this Oct 10, 2019
@AlexTugarev AlexTugarev added the notifications issues related to notifications label Oct 10, 2019
AlexTugarev added a commit that referenced this issue Oct 10, 2019
Fixes #5578

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Oct 11, 2019
also cleaned up unused `NotificationMain.$startProgress` options.

Fixes #5578

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Oct 11, 2019
also cleaned up unused `NotificationMain.$startProgress` options.

Fixes #5578

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
@tetchel
Copy link
Contributor Author

tetchel commented Oct 11, 2019

Now that's service! ❤️

@AlexTugarev
Copy link
Contributor

Thanks for reporting, btw.

akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
also cleaned up unused `NotificationMain.$startProgress` options.

Fixes eclipse-theia#5578

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help notifications issues related to notifications plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants