Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webview] refactor to be integrated with WidgetManager #5648

Closed
akosyakov opened this issue Jul 5, 2019 · 1 comment
Closed

[webview] refactor to be integrated with WidgetManager #5648

akosyakov opened this issue Jul 5, 2019 · 1 comment
Assignees
@akosyakov
Labels
vscode issues related to VSCode compatibility webviews issues related to webviews

Comments

@akosyakov
Copy link
Member

Right now the shell is not aware of web views making it impossible to restore them.
@akosyakov akosyakov added vscode issues related to VSCode compatibility webviews issues related to webviews labels Jul 5, 2019
@akosyakov akosyakov mentioned this issue Jul 5, 2019
Closed
@akosyakov
Copy link
Member Author

After it done, we can try to preserve webviews on reconnection.

@akosyakov akosyakov self-assigned this Oct 28, 2019
akosyakov added a commit that referenced this issue Oct 28, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
9601c73 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Oct 30, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
cef5893 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 1, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
623890a 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 7, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
179c2a3 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 8, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
6378252 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix eclipse-theia#5648: integrate webviews with the applica…
f1bf407 
…tion shell

It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Nov 13, 2019
@akosyakov
[webview] fix eclipse-theia#5648: integrate webviews with the applica…
7d827e3 
…tion shell

It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 13, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
791c135 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 14, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
cbe7ac8 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 15, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
530342b 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 16, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
9ebf180 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 18, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
50ac4a4 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 19, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
ba5bac7 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 21, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
ddef1e8 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 21, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
6078e63 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 22, 2019
@akosyakov
[webview] fix #5648: integrate webviews with the application shell
95b9691 
It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[webview] fix eclipse-theia#5648: integrate webviews with the applica…
bc39b81 
…tion shell

It requires to preserve webviews on reload and reconnection.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akosyakov