Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching file displays "No results found" while waiting the feed back from the search #5698

Closed
lmcbout opened this issue Jul 11, 2019 · 2 comments · Fixed by #5701
Closed

Searching file displays "No results found" while waiting the feed back from the search #5698

lmcbout opened this issue Jul 11, 2019 · 2 comments · Fixed by #5701
Labels
bug bugs found in the application search in workspace issues related to the search-in-workspace

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Jul 11, 2019

Description

When performing a search file, between the time the user types something in the search text box and the answer to arrive, there is a message being display: " No results found"
Why do we display this message?, why not just put "Searching", "Wait" or anything else but "No results found"

Reproduction Steps

SearchNoFoundMessage

OS and Theia version:
Ubuntu and window
Theia 0.8.0

Diagnostics:
@vince-fugnitto vince-fugnitto added question user / developer questions search in workspace issues related to the search-in-workspace labels Jul 11, 2019
@vince-fugnitto
Copy link
Member

It looks like we render the search-info while waiting for the search to actually complete and at the time it displays the default for 0 results which is No Results Found. until it re-updates when the search completes. I'm not sure it's a huge issue as we display No Results Found when there are no nodes in the tree and a search term is present.

@kittaakos
Copy link
Contributor

I'm not sure it's a huge issue

+1

But it's still a bug, isn't it?

@kittaakos kittaakos added bug bugs found in the application and removed question user / developer questions labels Jul 12, 2019
@kittaakos kittaakos changed the title Question: Searching file displays "No results found" while waiting the feed back from the search Searching file displays "No results found" while waiting the feed back from the search Jul 12, 2019
vince-fugnitto added a commit that referenced this issue Jul 12, 2019
@vince-fugnitto
Fix search-in-workspace search result info
26daf22 
Fixes #5698

- fixes an issue where the message `No Results Found.` is displayed
as a user types and attempts to search. The problem is that the message
is displayed before the search actually completes due to a `update()`.
Instead, the update to the widget is performed once the `search-in-workspace-tree`
completes it's search and fires the event `onDidChange()`.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Jul 12, 2019
Merged
vince-fugnitto added a commit that referenced this issue Jul 12, 2019
@vince-fugnitto
Fix search-in-workspace search result info
12f8ad2 
Fixes #5698

- fixes an issue where the message `No Results Found.` is displayed
as a user types and attempts to search. The problem is that the message
is displayed before the search actually completes due to a `update()`.
Instead, the update to the widget is performed once the `search-in-workspace-tree`
completes it's search and fires the event `onDidChange()`.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[search-in-workspace] fix search-in-workspace search result info eclipse-theia/theia
3 participants
@lmcbout @kittaakos @vince-fugnitto