-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui/ux] inconsistency between 'no-markers' and 'no-outline' messages #5716
Labels
ui/ux
issues related to user interface / user experience
Comments
vince-fugnitto
added
the
ui/ux
issues related to user interface / user experience
label
Jul 16, 2019
vince-fugnitto
added a commit
that referenced
this issue
Jul 16, 2019
Fixes #5716 - fixed the inconsistent padding present in the `outline` and `problems` view when no information is present. - added a new `widget.css` file which will be used to describe widget specific styling - added the new css class `theia-widget-noInfo` used for widget messages Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added a commit
that referenced
this issue
Jul 16, 2019
Fixes #5716 - fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present. - added a new `widget.css` file which will be used to describe widget specific styling - added the new css class `theia-widget-noInfo` used for widget messages Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
We should use relative padding with |
vince-fugnitto
added a commit
that referenced
this issue
Jul 16, 2019
Fixes #5716 - fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present. - added a new `widget.css` file which will be used to describe widget specific styling - added the new css class `theia-widget-noInfo` used for widget messages Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added a commit
that referenced
this issue
Jul 16, 2019
Fixes #5716 - fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present. - added a new `widget.css` file which will be used to describe widget specific styling - added the new css class `theia-widget-noInfo` used for widget messages Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added a commit
that referenced
this issue
Jul 18, 2019
Fixes #5716 - fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present. - added a new `widget.css` file which will be used to describe widget specific styling - added the new css class `theia-widget-noInfo` used for widget messages Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There is an inconsistency between the
no-markers
andno-outline
messages which are used to display when there are no information present in the view.The
padding
values are inconsistent:https://github.com/theia-ide/theia/blob/e830fbc2a32d62e3077e0179bfa2db5bb1f0b0c1/packages/markers/src/browser/style/index.css#L22-L24
https://github.com/theia-ide/theia/blob/e830fbc2a32d62e3077e0179bfa2db5bb1f0b0c1/packages/outline-view/src/browser/styles/index.css#L21-L25
The text was updated successfully, but these errors were encountered: