Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui/ux] inconsistency between 'no-markers' and 'no-outline' messages #5716

Closed
vince-fugnitto opened this issue Jul 16, 2019 · 1 comment · Fixed by #5717
Closed

[ui/ux] inconsistency between 'no-markers' and 'no-outline' messages #5716

vince-fugnitto opened this issue Jul 16, 2019 · 1 comment · Fixed by #5717
Labels
ui/ux issues related to user interface / user experience

Comments

@vince-fugnitto
Copy link
Member

Description

There is an inconsistency between the no-markers and no-outline messages which are used to display when there are no information present in the view.

The padding values are inconsistent:

https://github.com/theia-ide/theia/blob/e830fbc2a32d62e3077e0179bfa2db5bb1f0b0c1/packages/markers/src/browser/style/index.css#L22-L24

https://github.com/theia-ide/theia/blob/e830fbc2a32d62e3077e0179bfa2db5bb1f0b0c1/packages/outline-view/src/browser/styles/index.css#L21-L25


Screen Shot 2019-07-15 at 8 29 24 PM
@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Jul 16, 2019
vince-fugnitto added a commit that referenced this issue Jul 16, 2019
Fixes #5716

- fixed the inconsistent padding present in the `outline` and `problems` view when no information is present.
- added a new `widget.css` file which will be used to describe widget specific styling
- added the new css class `theia-widget-noInfo` used for widget messages

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Jul 16, 2019
Fixes #5716

- fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present.
- added a new `widget.css` file which will be used to describe widget specific styling
- added the new css class `theia-widget-noInfo` used for widget messages

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@akosyakov
Copy link
Member

We should use relative padding with --theia-ui-padding variable.

vince-fugnitto added a commit that referenced this issue Jul 16, 2019
Fixes #5716

- fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present.
- added a new `widget.css` file which will be used to describe widget specific styling
- added the new css class `theia-widget-noInfo` used for widget messages

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Jul 16, 2019
Fixes #5716

- fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present.
- added a new `widget.css` file which will be used to describe widget specific styling
- added the new css class `theia-widget-noInfo` used for widget messages

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Jul 18, 2019
Fixes #5716

- fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present.
- added a new `widget.css` file which will be used to describe widget specific styling
- added the new css class `theia-widget-noInfo` used for widget messages

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants