Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plug-in] improve the retrieval of icons in webviews #5786

Closed
vince-fugnitto opened this issue Jul 23, 2019 · 0 comments · Fixed by #6465
Closed

[plug-in] improve the retrieval of icons in webviews #5786

vince-fugnitto opened this issue Jul 23, 2019 · 0 comments · Fixed by #6465
Assignees
@akosyakov
Labels
plug-in system issues related to the plug-in system quality issues related to code and application quality webviews issues related to webviews

Comments

@vince-fugnitto
Copy link
Member

Description

Originally discussed here

Improve the retrieval of icons consumed by webviews.
The plug-in system should properly convert iconPath to iconUrl in order to get icons similarly to the tree-view icons.

The problem is that additional enpoints are therefore needed to fetch icons for webviews and the code deviates from the standard solution. The code can be simplified in order to use the proper implementation.

cc @akosyakov
@vince-fugnitto vince-fugnitto added quality issues related to code and application quality plug-in system issues related to the plug-in system labels Jul 23, 2019
@akosyakov akosyakov added the webviews issues related to webviews label Jul 28, 2019
@akosyakov akosyakov self-assigned this Oct 30, 2019
akosyakov added a commit that referenced this issue Oct 31, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
75289a0 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Oct 31, 2019
Merged
37 tasks
akosyakov added a commit that referenced this issue Nov 1, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
337322b 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 1, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
ffd0996 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 7, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
efedfe4 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 7, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
f0a78d8 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 8, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
45afac9 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
2c9501f 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
48d89eb 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
6ebc3f8 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix eclipse-theia#5786: unify the icon path resolution
62c5c6e 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Nov 13, 2019
@akosyakov
[webview] fix eclipse-theia#5786: unify the icon path resolution
16850c8 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 13, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
b4129ab 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 13, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
c96dd13 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 14, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
35f7c51 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 14, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
8086f21 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 14, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
3fdaa29 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 15, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
ec388de 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 16, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
d26a6d3 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 16, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
9d702b7 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 18, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
6f8bffa 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 19, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
fa92863 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 21, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
0f56493 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 21, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
478db7e 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 21, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
2f449dc 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 22, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
64c49f8 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 22, 2019
@akosyakov
[webview] fix #5786: unify the icon path resolution
6db38b2 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[webview] fix eclipse-theia#5786: unify the icon path resolution
e1c3c43 
Also:
- preserve the icon path between user sessions and reconnections
- add missing icon-path getter api

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
plug-in system issues related to the plug-in system quality issues related to code and application quality webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

complete support of webviews eclipse-theia/theia
2 participants
@akosyakov @vince-fugnitto