Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

direction key can't select suggest view #6168

Closed
502647092 opened this issue Sep 12, 2019 · 1 comment · Fixed by #6170
Closed

direction key can't select suggest view #6168

502647092 opened this issue Sep 12, 2019 · 1 comment · Fixed by #6170
Assignees
@akosyakov
Labels
bug bugs found in the application monaco issues related to monaco

Comments

@502647092
Copy link
Contributor

Description

after yesterday build
direction key can't select suggest view

before build
temp

after build
temp

@akosyakov

Reproduction Steps

OS and Theia version:
Diagnostics:
@akosyakov akosyakov added bug bugs found in the application monaco issues related to monaco labels Sep 12, 2019
@akosyakov akosyakov self-assigned this Sep 12, 2019
@akosyakov
Copy link
Member

akosyakov commented Sep 12, 2019 •
edited
Loading

@502647092 Could you provide a repo where i can reproduce it? It works in theia repo for me. Also browser version and OS? - was able to reproduce

@akosyakov akosyakov added 🤔 needs more info issues that require more info from the author and removed 🤔 needs more info issues that require more info from the author labels Sep 12, 2019
akosyakov added a commit that referenced this issue Sep 12, 2019
@akosyakov
fix #6168: register Monaco keybindings in reverse order
028055c 
in order to match to Monaco keybindings dispatch logic

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Sep 12, 2019
Merged
1 task
akosyakov added a commit that referenced this issue Sep 12, 2019
@akosyakov
fix #6168: register Monaco keybindings in reverse order
b2caa12 
in order to match to Monaco keybindings dispatch logic

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Sep 12, 2019
@akosyakov
fix #6168: register Monaco keybindings in reverse order
d0690be 
in order to match to Monaco keybindings dispatch logic

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
fix eclipse-theia#6168: register Monaco keybindings in reverse order
6d3707f 
in order to match to Monaco keybindings dispatch logic

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application monaco issues related to monaco
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

register Monaco keybindings in reverse order eclipse-theia/theia
2 participants
@akosyakov @502647092