Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quality][workspace-service] WorkspaceService#getDefaultWorkspacePath is misleading. Deprecate it #6432

Closed
kittaakos opened this issue Oct 22, 2019 · 0 comments · Fixed by #6437
Closed

[quality][workspace-service] WorkspaceService#getDefaultWorkspacePath is misleading. Deprecate it #6432

kittaakos opened this issue Oct 22, 2019 · 0 comments · Fixed by #6437
Labels
help wanted issues meant to be picked up, require help quality issues related to code and application quality workspace issues related to the workspace

Comments

@kittaakos
Copy link
Contributor

Description

theia/packages/workspace/src/browser/workspace-service.ts

Line 93 in f255f5a

protected getDefaultWorkspacePath(): MaybePromise<string | undefined> {
returns with the URI as a string, and not a Path. It is misleading.

Introduce a new getDefaultWorkspaceUri, move the logic from getDefaultWorkspacePath to the new method. Delegate from getDefaultWorkspacePath to the new getDefaultWorkspaceUri.

Reproduction Steps

OS and Theia version:

Diagnostics:
@kittaakos kittaakos added quality issues related to code and application quality workspace issues related to the workspace labels Oct 22, 2019
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Oct 23, 2019
kittaakos pushed a commit that referenced this issue Oct 23, 2019
GH-6432: Deprecated getDefaultWorkspacePath.
0c6d4b5 
Use `WorkspaceService#getDefaultWorkspaceUri` instead.

Closes #6432

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Oct 23, 2019
Merged
1 task
kittaakos pushed a commit that referenced this issue Oct 23, 2019
@kittaakos
GH-6432: Deprecated getDefaultWorkspacePath.
d26b6f8 
Use `WorkspaceService#getDefaultWorkspaceUri` instead.

Closes #6432

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
eclipse-theiaGH-6432: Deprecated getDefaultWorkspacePath.
8ad626d 
Use `WorkspaceService#getDefaultWorkspaceUri` instead.

Closes eclipse-theia#6432

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted issues meant to be picked up, require help quality issues related to code and application quality workspace issues related to the workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-6432: Deprecated getDefaultWorkspacePath. eclipse-theia/theia
2 participants
@kittaakos @akosyakov