-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated terminal should not be resused if a process is running in it #6767
Labels
bug
bugs found in the application
debug
issues that related to debug functionality
help wanted
issues meant to be picked up, require help
vscode
issues related to VSCode compatibility
Comments
akosyakov
added
bug
bugs found in the application
debug
issues that related to debug functionality
help wanted
issues meant to be picked up, require help
vscode
issues related to VSCode compatibility
labels
Dec 18, 2019
@a1994846931931 PRs are welcomed. |
a1994846931931
added a commit
to a1994846931931/theia
that referenced
this issue
Dec 18, 2019
…d processes Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
a1994846931931
added a commit
to a1994846931931/theia
that referenced
this issue
Dec 18, 2019
…d processes Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
2 tasks
a1994846931931
added a commit
to a1994846931931/theia
that referenced
this issue
Dec 18, 2019
Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
a1994846931931
added a commit
to a1994846931931/theia
that referenced
this issue
Dec 18, 2019
…d processes Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
a1994846931931
added a commit
to a1994846931931/theia
that referenced
this issue
Dec 18, 2019
Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
a1994846931931
added a commit
to a1994846931931/theia
that referenced
this issue
Dec 19, 2019
…d processes Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
a1994846931931
added a commit
to a1994846931931/theia
that referenced
this issue
Dec 19, 2019
Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
a1994846931931
added a commit
that referenced
this issue
Jan 21, 2020
Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
a1994846931931
added a commit
that referenced
this issue
Jan 21, 2020
Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
akosyakov
pushed a commit
to akosyakov/theia
that referenced
this issue
Feb 24, 2020
…d processes Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
akosyakov
pushed a commit
to akosyakov/theia
that referenced
this issue
Feb 24, 2020
Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
JesterOrNot
pushed a commit
to JesterOrNot/theia
that referenced
this issue
Mar 12, 2020
…d processes Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
JesterOrNot
pushed a commit
to JesterOrNot/theia
that referenced
this issue
Mar 12, 2020
Signed-off-by: Cai Xuye <a1994846931931@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
bugs found in the application
debug
issues that related to debug functionality
help wanted
issues meant to be picked up, require help
vscode
issues related to VSCode compatibility
Description
If a process is running in an integrated terminal, then a new integrated terminal should be provided for
runInTerminal
request. Otherwise, it could be problematic, even dangerous.Reproduction Steps
In the demo above, if the terminal is already running python, sending command text to that terminal will end in chaos.
What's worse? Think about a situation where a user happens to be operating a database, e.g. MySQL, in the opened integrated terminal, it could be dangerous to send commands to that terminal!
Propose
I learned the logic from VSCode. Please refer to:
https://github.com/microsoft/vscode/blob/4636be2b71c87bfb0bfe3c94278b447a5efcc1f1/src/vs/workbench/api/node/extHostDebugService.ts#L83-L87
and
https://github.com/microsoft/vscode/blob/4636be2b71c87bfb0bfe3c94278b447a5efcc1f1/src/vs/workbench/contrib/debug/node/terminals.ts#L50-L75
Demo from VSCode:
Compare the title of the integrated terminal of VSCode to theia:
VSCode:
Theia:
OS and Theia version:
OS: Linux
Theia: Latest(582ae9d)
Diagnostics:
The text was updated successfully, but these errors were encountered: