-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[theming] changing themes quickly results in a dialog #6786
Comments
I don't think it can happen often, does it? I had hard time to reproduce it. |
but it breaks tests from time to time, i.e. #5774 failing because of it |
Oh, basically we need to reimplement logic from the monaco editor model to handle concurrent updates for resource. I think we are better to rewrite |
That's tricky:
I think we can do it after #6409 that we can port tests to run within the app. |
|
It should be fixed with #7110. @vince-fugnitto could you try? |
Description
Using #6475, if a user changes themes quickly, a dialog is displayed that there is inconsistency in the global
settings.json
in the editor and on the filesystem (auto-save is off)Steps to Reproduce
settings.json
.The text was updated successfully, but these errors were encountered: