Update of preferences from VSCode plugin triggers multiple overwrite popup confirmation

[crawr]

Description

It seems there is an inconsistency between the vscode.workspace.getConfiguration().update API in VSCode and Theia.
Even though there are no changes in the configuration, the update is triggered and is trying to overwrite the contents in the settings.json file.

Is there a way to turn off the overwrite confirmation?
Is this a bug in the FileSystem watcher?

Reproduction Steps

Extension: Zowe Explorer
Whenever the browser is refreshed or left idle for a while, the following popup appears multiple times:

OS and Theia version:
Windows 10
latest Theia

[vince-fugnitto]

Related #6786

[akosyakov]

@vince-fugnitto yes, I think the fix should handle both cases

[venkatzhub]

@akosyakov - The above mentioned error message is happening very frequently. Our end users/customers of Zowe Explorer are experiencing this a lot and are complaining about it. Wondering if there is a workaround of some sort to at least minimize the frequency of the pop up, while you are working on the fix?

[vince-fugnitto]

@akosyakov - The above mentioned error message is happening very frequently. Our end users/customers of Zowe Explorer are experiencing this a lot and are complaining about it. Wondering if there is a workaround of some sort to at least minimize the frequency of the pop up, while you are working on the fix?

I think if you don't want to display the dialog any longer until there is a proper fix, you can unbind the following:

theia/packages/filesystem/src/browser/filesystem-frontend-module.ts

Lines 44 to 53 in 554f99e

	bind(FileShouldOverwrite).toDynamicValue(context => async (file: FileStat, stat: FileStat): Promise<boolean> => {
	const labelProvider = context.container.get(LabelProvider);
	const dialog = new ConfirmDialog({
	title: `The file '${labelProvider.getName(new URI(file.uri))}' has been changed on the file system.`,
	msg: `Do you want to overwrite the changes made to '${labelProvider.getLongName(new URI(file.uri))}' on the file system?`,
	ok: 'Yes',
	cancel: 'No'
	});
	return !!await dialog.open();
	}).inSingletonScope();

[venkatzhub]

@vince-fugnitto - Thank you, we will try that.

[akosyakov]

I had to fix tests yet, but could someone try please whether you can reproduce it with #7110?