Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align task items #6821

Closed
RomanNikitenko opened this issue Jan 4, 2020 · 0 comments · Fixed by #7392
Closed

Align task items #6821

RomanNikitenko opened this issue Jan 4, 2020 · 0 comments · Fixed by #7392
Assignees
@elaihau
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system

Comments

@RomanNikitenko
Copy link
Contributor

Description

Items for tasks related menus look different.
Please see the video: https://youtu.be/2Fi908GFelk

You can see that for Run Task and Restart Running Task the detected tasks look like:

  • tsc : watch - tsconfig.json theia
  • tsc : watch - tsconfig.json vscode-builtin-extensions

but for Terminate Task and Show Running Tasks the same tasks look like:

  • watch - tsconfig.json
  • watch - tsconfig.json

It's impossible to recognize the corresponding task for last case.
So, would be nice to improve the behavior.

Reproduction Steps

Try to use:

  • Run Task
  • Restart Running Task
  • Terminate Task
  • Show Running Tasks

menus for detected tasks for multi root workspace.
Please see the video above.

OS and Theia version:
Ubuntu 18.04
Theia ec2a866
@RomanNikitenko RomanNikitenko added enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system labels Jan 4, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Jan 8, 2020
Closed
8 tasks
@elaihau elaihau self-assigned this Mar 22, 2020
elaihau added a commit that referenced this issue Mar 22, 2020
@elaihau
align how tasks are displayed as quick open items
789245b 
- In a multi root workspace, detected tasks are displayed in different
ways across `Run task`, `Restart running task`, `Terminate task`,
and `Show running tasks`. This change aligns the display of the task
quick open items.
- fixed #6821

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
@elaihau elaihau mentioned this issue Mar 22, 2020
Merged
1 task
elaihau added a commit that referenced this issue Mar 22, 2020
@elaihau
align how tasks are displayed as quick open items
2043d91 
- In a multi root workspace, detected tasks are displayed in different
ways across `Run task`, `Restart running task`, `Terminate task`,
and `Show running tasks`. This change aligns the display of the task
quick open items.
- fixed #6821

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
elaihau added a commit that referenced this issue Mar 23, 2020
@elaihau
align how tasks are displayed as quick open items
1817687 
- In a multi root workspace, detected tasks are displayed in different
ways across `Run task`, `Restart running task`, `Terminate task`,
and `Show running tasks`. This change aligns the display of the task
quick open items.
- fixed #6821

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
elaihau added a commit that referenced this issue Mar 24, 2020
@elaihau
align how tasks are displayed as quick open items
ceb7a31 
- In a multi root workspace, detected tasks are displayed in different
ways across `Run task`, `Restart running task`, `Terminate task`,
and `Show running tasks`. This change aligns the display of the task
quick open items.
- fixed #6821

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
elaihau added a commit that referenced this issue Mar 24, 2020
@elaihau
align how tasks are displayed as quick open items
8152c55 
- In a multi root workspace, detected tasks are displayed in different
ways across `Run task`, `Restart running task`, `Terminate task`,
and `Show running tasks`. This change aligns the display of the task
quick open items.
- fixed #6821

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

align how tasks are displayed as quick open items eclipse-theia/theia
2 participants
@RomanNikitenko @elaihau