[theming] minimap is incorrectly decorated for scm updates (additions, modifications) #6839
Labels
bug
bugs found in the application
help wanted
issues meant to be picked up, require help
scm
issues related to the source control manager
theming
issues related to theming
Comments
vince-fugnitto
added
bug
|
It looks like all minimap color decorations do not work at the moment, even during testing of adding pre-existing colors to other decorators (ex: |
vince-fugnitto
added a commit
that referenced
this issue
Mar 12, 2020
Fixes #6839 This commit fixes the following problems: - `overviewRuler` colors were not applied properly for the `scm` extension - `minimap` colors were not applied properly for the `scm` extension - colors (`overviewRuler`) are updated to align with vscode Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
5 tasks
vince-fugnitto
added a commit
that referenced
this issue
Mar 13, 2020
Fixes #6839 This commit fixes the following problems: - `overviewRuler` colors were not applied properly for the `scm` extension - `minimap` colors were not applied properly for the `scm` extension - colors (`overviewRuler`) are updated to align with vscode Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added a commit
that referenced
this issue
Apr 24, 2020
Fixes #6839 This commit fixes the following problems: - `overviewRuler` colors were not applied properly for the `scm` extension - `minimap` colors were not applied properly for the `scm` extension - colors (`overviewRuler`) are updated to align with vscode Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added a commit
that referenced
this issue
Apr 24, 2020
Fixes #6839 The following commit fixes the following problems: - fixes the `DecorationOptions#color` to accept `ids` of color variables. - fixes the decorations provided by `scm` (additions, modifications, removals). - fixes the color variables for `scm`, aligning the values with vscode. - fixes the decorations provided by the `siw` (search-in-workspace). Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added a commit
that referenced
this issue
Apr 27, 2020
Fixes #6839 The following commit fixes the following problems: - fixes the `DecorationOptions#color` to accept `ids` of color variables. - fixes the decorations provided by `scm` (additions, modifications, removals). - fixes the color variables for `scm`, aligning the values with vscode. - fixes the decorations provided by the `siw` (search-in-workspace). Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
yenteewt
added a commit
to yenteewt/theia
that referenced
this issue
Apr 27, 2020
Fixes eclipse-theia#6839 The following commit fixes the following problems: - fixes the `DecorationOptions#color` to accept `ids` of color variables. - fixes the decorations provided by `scm` (additions, modifications, removals). - fixes the color variables for `scm`, aligning the values with vscode. - fixes the decorations provided by the `siw` (search-in-workspace). Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The minimap is incorrectly decorated for modified, and added lines (always red).
The minimap should be correctly decorated similarly to the
diff-editor.Single Editor:
Diff Editor:
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: