Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[terminal] improve the display of 'new terminal' for multiple roots #6874

Closed
vince-fugnitto opened this issue Jan 13, 2020 · 0 comments · Fixed by #6876
Closed

[terminal] improve the display of 'new terminal' for multiple roots #6874

vince-fugnitto opened this issue Jan 13, 2020 · 0 comments · Fixed by #6876
Assignees
@vince-fugnitto
Labels
enhancement issues that are enhancements to current functionality - nice to haves multi-root issues related to multi-root support terminal issues related to the terminal

Comments

@vince-fugnitto
Copy link
Member

Description

The display for New Terminal entries should be improved to display the root names, and the uri as descriptions so they are more readable. At the moment, the uri is displayed completely which makes it hard to read especially for longer paths.

In the following example, the roots are theia and theia-copy but it is difficult to visually grep.
It becomes worse when there are multiple folders, and the paths are relatively long.

image
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves terminal issues related to the terminal multi-root issues related to multi-root support labels Jan 13, 2020
@vince-fugnitto vince-fugnitto self-assigned this Jan 13, 2020
vince-fugnitto added a commit that referenced this issue Jan 13, 2020
@vince-fugnitto
[terminal] improve the display of 'new terminal'
b6c2a8c 
Fixes #6874

- improves the display of `new terminal` items when running in a multi-root workspace.
- adds the `root name` as a label, and displays the `uri` as a description.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Jan 13, 2020
@vince-fugnitto
[terminal] improve the display of 'new terminal'
fd9abe1 
Fixes #6874

- improves the display of `new terminal` items when running in a multi-root workspace.
- adds the `root name` as a label, and displays the `uri` as a description.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Jan 13, 2020
Merged
1 task
vince-fugnitto added a commit that referenced this issue Jan 14, 2020
@vince-fugnitto
[terminal] improve the display of 'new terminal'
30e88c8 
Fixes #6874

- improves the display of `new terminal` items when running in a multi-root workspace.
- adds the `root name` as a label, and displays the `uri` as a description.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@vince-fugnitto @akosyakov
[terminal] improve the display of 'new terminal'
fcae1fd 
Fixes eclipse-theia#6874

- improves the display of `new terminal` items when running in a multi-root workspace.
- adds the `root name` as a label, and displays the `uri` as a description.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vince-fugnitto vince-fugnitto

Labels
enhancement issues that are enhancements to current functionality - nice to haves multi-root issues related to multi-root support terminal issues related to the terminal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[terminal] improve the display of 'new terminal' eclipse-theia/theia
1 participant
@vince-fugnitto