Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.showQuickPick is never resolve if closed with esc #6929

Closed
akosyakov opened this issue Jan 21, 2020 · 2 comments
Closed

window.showQuickPick is never resolve if closed with esc #6929

akosyakov opened this issue Jan 21, 2020 · 2 comments
Assignees
@akosyakov
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

It should resolve with undefined
@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Jan 21, 2020
@akosyakov akosyakov self-assigned this Jan 21, 2020
@benoitf
Copy link
Contributor

benoitf commented Jan 21, 2020

report is quite obvious but maybe you could reference existing VS Code extension that is reproducing the error ?

@akosyakov
Copy link
Member Author

akosyakov commented Jan 21, 2020 •
edited
Loading

I got it with vscode-gitlens, it never unsets context keys which should happen after showQuickPick exits: https://github.com/eamodio/vscode-gitlens/blob/30e1d290e8f337d56596a030ff097eeabdd98eb7/src/quickpicks/commitQuickPick.ts#L220-L241

akosyakov added a commit to akosyakov/theia that referenced this issue Jan 21, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
b7c7a5b 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Jan 22, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
db2696b 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Jan 23, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
366d5ad 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Jan 23, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
f3d9b50 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 7, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
e6d63b7 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 12, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
f8a7533 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 12, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
aa8d4f7 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 12, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
77e5105 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 12, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
8bca081 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
6a8b0f1 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
1a7d820 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
713f406 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 26, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
0c031b3 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 27, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
185e1ee 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 27, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
3af5e46 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 27, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
9c7d064 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 12, 2020
@akosyakov
[vscode] fix #6929, fix #5764: handle quick pick/input cancellation a…
932ef76 
…nd closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Apr 23, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
ee0d648 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue May 4, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
eb656df 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue May 7, 2020
@akosyakov
[vscode] fix eclipse-theia#6929, fix eclipse-theia#5764: handle quick…
c517df6 
… pick/input cancellation and closing properly

- resolve callback was never called if a user closed the widget
- token was never passed to the main side, so the widget was not hidden if an extension closes it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benoitf @akosyakov