Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to load plugin dependencies from ... path Error: ENOTDIR: not a directory #7240

Closed
tom-shan opened this issue Feb 28, 2020 · 0 comments · Fixed by #7242
Closed

Failed to load plugin dependencies from ... path Error: ENOTDIR: not a directory #7240

tom-shan opened this issue Feb 28, 2020 · 0 comments · Fixed by #7242
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system

Comments

@tom-shan
Copy link
Contributor

tom-shan commented Feb 28, 2020 •
edited
Loading

Description

when a plugin file is an symbolic link, theia will failed to load this plugin
ERROR Failed to load plugin dependencies from ... path Error: ENOTDIR: not a directory

Reproduction Steps

OS and Theia version:
OS: centos 7
Theia: c965552
Diagnostics:
https://github.com/eclipse-theia/theia/blob/master/packages/plugin-ext/src/main/node/plugin-deployer-entry-impl.ts#L75 treats the link self as the target, not the file the link refers to.
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system labels Feb 28, 2020
tom-shan added a commit to tom-shan/theia that referenced this issue Feb 28, 2020
@tom-shan
fix eclipse-theia#7240
ef1bec3 
using statSync instead of lstatSync, so isFile or isDirectory will
check what the symbolic link refer to but not the link itself.
tom-shan added a commit to tom-shan/theia that referenced this issue Feb 28, 2020
@tom-shan
fix eclipse-theia#7240
3729570 
using statSync instead of lstatSync, so isFile or isDirectory will
check what the symbolic link refer to but not the link itself.

Signed-off-by: tom-shan <swt0008411@163.com>
@tom-shan tom-shan mentioned this issue Feb 28, 2020
Merged
1 task
azatsarynnyy pushed a commit that referenced this issue Mar 4, 2020
@tom-shan @azatsarynnyy
fix #7240
3d5e4f9 
using statSync instead of lstatSync, so isFile or isDirectory will
check what the symbolic link refer to but not the link itself.

Signed-off-by: tom-shan <swt0008411@163.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@tom-shan
fix eclipse-theia#7240
84886cd 
using statSync instead of lstatSync, so isFile or isDirectory will
check what the symbolic link refer to but not the link itself.

Signed-off-by: tom-shan <swt0008411@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #7240: support loading plugins from symbolic links tom-shan/theia
2 participants
@akosyakov @tom-shan