Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theia should support editor.defaultFormatter key #7252

Closed
felipecrs opened this issue Mar 2, 2020 · 3 comments
Closed

Theia should support editor.defaultFormatter key #7252

felipecrs opened this issue Mar 2, 2020 · 3 comments
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@felipecrs
Copy link

felipecrs commented Mar 2, 2020 •
edited
Loading

This setting aims to set a default formatter for a language (or every language).

Reference and use case:
https://github.com/prettier/prettier-vscode/blob/master/README.md#default-formatter

In this project: https://gitpod.io/#https://github.com/felipecassiors/ubuntu1804-4dev, I want to enforce the default formatter to prettier, however, the Ruby one comes on by default. To make Prettier work for Ruby I have to edit any of its settings (and revert back), and then Prettier starts to work for Ruby.
felipecrs added a commit to felipecrs/dev-ubuntu that referenced this issue Mar 2, 2020
@felipecrs
chore(gitpod): install extensions and dependencies
84c1dba 
- adds prettier support for Ruby and Shell files, however due to
  eclipse-theia/theia#7252 the prettier
  isn't being enabled for Ruby by default. You have to manually
  change any of its settings in order to activate it.
- adds extensions for Markdown, Shell and Ruby
- install Vagrant in order to use `vagrant validate -p`
- format the Vagratfiles
- add some default workspace settings, reference:
  gitpod-io/gitpod#1279
felipecrs added a commit to felipecrs/dev-ubuntu that referenced this issue Mar 2, 2020
@felipecrs
chore(gitpod): install extensions and dependencies
f4a454e 
- adds prettier support for Ruby and Shell files, however due to
  eclipse-theia/theia#7252 the prettier
  isn't being enabled for Ruby by default. You have to manually
  change any of its settings in order to activate it.
- adds extensions for Markdown, Shell and Ruby
- install Vagrant in order to use `vagrant validate -p`
- format the Vagratfiles
- add some default workspace settings, reference:
  gitpod-io/gitpod#1279
@akosyakov akosyakov added editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility labels Mar 2, 2020
@Eliav2
Copy link

Eliav2 commented Apr 13, 2021

hey friend - can you explain in more detail what you did to make prettier work? I'm facing the same issue with javascript/typescript files

@felipecrs
Copy link
Author

Hi @Eliav2. I'm not sure, it has been a while and I'm not using Theia anymore. A lot has changed since I opened this issue also.

@vince-fugnitto
Copy link
Member

I believe #8446 resolved the issue 👍 Please comment again if it's not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@akosyakov @felipecrs @vince-fugnitto @Eliav2