Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question: can the 'plugins view' be removed? #7375

Open
vince-fugnitto opened this issue Mar 19, 2020 · 4 comments
Open

question: can the 'plugins view' be removed? #7375

vince-fugnitto opened this issue Mar 19, 2020 · 4 comments
Labels
plug-in system issues related to the plug-in system question user / developer questions vsx-registry Issues related to Open VSX Registry Integration

Comments

@vince-fugnitto
Copy link
Member

Description

Since we now have the extension view as part of the vsx integration (#6655), is there a need to keep the plugins view? At the moment, it is possible to have both views in a given application.

If we are to remove the plugins view, I think it should be done before v1.0.0.

cc @eclipse-theia/core
@vince-fugnitto vince-fugnitto added question user / developer questions plug-in system issues related to the plug-in system vsx-registry Issues related to Open VSX Registry Integration labels Mar 19, 2020
vince-fugnitto added a commit that referenced this issue Mar 20, 2020
@vince-fugnitto
plugins: remove the plugins-view
0846a35 
Fixes #7375

the following commit removes the `plugins-view` widget from the
framework since it's been replaced by the `extensions-view` which
allows users the ability to install plugins from the Open VSX Registry.

Since the `extension-view` widget is added, there is no longer a need
to keep the `plugins-view`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Mar 20, 2020
Closed
1 task
@akosyakov
Copy link
Member

I don't think it has to be done before v1.0.0.

@vince-fugnitto vince-fugnitto mentioned this issue Jun 22, 2020
Open
@vince-fugnitto vince-fugnitto mentioned this issue Jan 22, 2024
Open
@jcortell68
Copy link
Contributor

Chiming in that this view confused us the other day. Someone noticed the existence of the Plugins view and we had some back and forth trying to guess at why it might exist and wondering if it was any different than the extensions view. If it was mostly the same, did it maybe have something special about it? Anyway, removing it will probably save others from the same down the road.

@tsmaeder
Copy link
Contributor

The technical difference I see is that the plugins view is not linked to a plugins marketplace (OpenVSX) in any way: it just shows what it installed in the system without offering to install any more plugins. Wanting to remove the ability to view and install plugins is a legit requirement, IMO for Theia applications that are not general purpose IDEs. Whether we want to see what plugins are installed in this case is open to discussion.

@tsmaeder
Copy link
Contributor

Cleanly separating plugin installation/deployment/usage is another hobby horse of mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plug-in system issues related to the plug-in system question user / developer questions vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plugins: remove the plugins-view eclipse-theia/theia
4 participants
@akosyakov @tsmaeder @vince-fugnitto @jcortell68