Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit "When" field in keyboard shortcuts editor #7551

Closed
dsseng opened this issue Apr 12, 2020 · 1 comment
Closed

Unable to edit "When" field in keyboard shortcuts editor #7551

dsseng opened this issue Apr 12, 2020 · 1 comment
Labels
help wanted issues meant to be picked up, require help keybindings issues related to keybindings ui/ux issues related to user interface / user experience

Comments

@dsseng
Copy link
Contributor

dsseng commented Apr 12, 2020

Description

When trying to edit keyboard shortcuts from the UI I can't edit When. I can only do so after I create a custom keybinding and edit it in JSON.
In VS Code a context menu pops up when user right-clicks on a keybinding, like this:
image
2nd item from the and means Change When expression, this is the option I couldn't find in Theia.

Reproduction Steps

  1. Open Keyboard Shortcuts (Ctrl+Alt+,)
  2. Try to find any button or right-click on a keybinding item
  3. Find no way to set its When condition

OS and Theia version:
OS: Ubuntu 19.10
Theia: master

Diagnostics:

@vince-fugnitto vince-fugnitto added keybindings issues related to keybindings ui/ux issues related to user interface / user experience labels Apr 13, 2020
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Apr 14, 2020
@vince-fugnitto
Copy link
Member

Closing in favor of #7582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issues meant to be picked up, require help keybindings issues related to keybindings ui/ux issues related to user interface / user experience
Projects
None yet
Development

No branches or pull requests

3 participants