keybindings: add context-menu to keyboard shortcuts #7582
Labels
enhancement
issues that are enhancements to current functionality - nice to haves
keybindings
issues related to keybindings
Comments
vince-fugnitto
added
enhancement
|
If help is wanted with this issue, I can start working on a PR. |
|
@pisv go ahead :) |
|
ОК, here I go :) |
pisv
added a commit
to pisv/theia
that referenced
this issue
Aug 1, 2023
Fixes the bulk of eclipse-theia#7582. Adds a context menu to the Keyboard Shorcuts editor with the following menu items: - Copy - Copy Command ID - Copy Command Title - Edit Keybinding... - Edit When Expression... - Add Keybinding... - Remove Keybinding - Reset Keybinding - Show Same Keybindings This commit does not address the bonus part of eclipse-theia#7582, i.e. no keybindings are provided for the menu items.
1 task
|
Created PR #12791. @vince-fugnitto Can you please take a look? |
pisv
added a commit
to pisv/theia
that referenced
this issue
Oct 16, 2023
pisv
added a commit
to pisv/theia
that referenced
this issue
Oct 16, 2023
pisv
added a commit
to pisv/theia
that referenced
this issue
Oct 20, 2023
pisv
added a commit
to pisv/theia
that referenced
this issue
Oct 20, 2023
tsmaeder
pushed a commit
that referenced
this issue
Oct 21, 2023
* keybindings: add context menu to keyboard shortcuts Fixes the bulk of #7582. Adds a context menu to the Keyboard Shorcuts editor with the following menu items: - Copy - Copy Command ID - Copy Command Title - Edit Keybinding... - Edit When Expression... - Add Keybinding... - Remove Keybinding - Reset Keybinding - Show Same Keybindings This commit does not address the bonus part of #7582, i.e. no keybindings are provided for the menu items. * Address review comments Removed excessive `public` modifiers and `setTimeout` call. * Address review comments Added a label for each of the new commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The keyboard shortcuts view should include a context-menu from which we can have additional commands (similarly to vscode). Such commands include:
Copy: (adds the ability to copy the keybinding's JSON object):{ "key": "shift+alt+h", "command": "references-view.showCallHierarchy", "when": "editorHasCallHierarchyProvider" }Copy Command ID: (copies the keybinding's command id)Change Keybinding: (triggers the update keybinding dialog)Remove Keybinding: (reverts a user-defined keybinding)Change When Expression: (updates the when/context of a keybinding)Show Same Keybinding: (searches for other commands with the same keybinding as the selection)Bonus 🏅
The new context-menu commands should be operable using the keyboard by providing them with keybindings.
The text was updated successfully, but these errors were encountered: