Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferences: provide input field validation #7741

Closed
vince-fugnitto opened this issue May 5, 2020 · 0 comments · Fixed by #8264
Closed

preferences: provide input field validation #7741

vince-fugnitto opened this issue May 5, 2020 · 0 comments · Fixed by #8264
Labels
enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

Following #7105, we should provide validation for input fields directly in the user-interface. This will give end-users instant feedback that the value they provided are incorrect, or of incorrect type. At the moment it is possible to provide values which are unexpected without any visual feedback:

Theia:

Screen Shot 2020-05-05 at 9 17 17 AM

VS Code:

Screen Shot 2020-05-05 at 9 16 46 AM

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences labels May 5, 2020
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 28, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 28, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 28, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 28, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 28, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 29, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 30, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 31, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 31, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 31, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 31, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 31, 2020
Fixes: eclipse-theia#7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
vince-fugnitto pushed a commit that referenced this issue Aug 11, 2020
Fixes: #7741

Added an input field validation in the preference widget.
Updated the input field type to be `number` instead of `text` for
numerical fields.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant