Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quality][preferences] PreferencesContribution does not follow the module name recommendations #8203

Closed
kittaakos opened this issue Jul 20, 2020 · 0 comments · Fixed by #8237
Closed

[quality][preferences] PreferencesContribution does not follow the module name recommendations #8203

kittaakos opened this issue Jul 20, 2020 · 0 comments · Fixed by #8237
Labels
good first issue good first issues for new contributors preferences issues related to preferences quality issues related to code and application quality

Comments

@kittaakos
Copy link
Contributor

Bug Description:

The module name is preference-contribution, the class name is PreferencesContribution.
https://github.com/eclipse-theia/theia/wiki/Coding-Guidelines#names

Steps to Reproduce:

Additional Information

  • Operating System:
  • Theia Version:
@kittaakos kittaakos added preferences issues related to preferences quality issues related to code and application quality good first issue good first issues for new contributors labels Jul 20, 2020
@minyoungyang minyoungyang mentioned this issue Jul 27, 2020
Closed
minyoungyang added a commit to minyoungyang/theia that referenced this issue Jul 27, 2020
@minyoungyang
[preferences] module name changed (preferences-contribution)
dba18aa 
Fixes: eclipse-theia#8203

This PR renames module from 'preference-contribution' to 'preferences-contribution'.

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
@minyoungyang minyoungyang mentioned this issue Jul 27, 2020
Merged
1 task
vince-fugnitto pushed a commit that referenced this issue Jul 28, 2020
@minyoungyang @vince-fugnitto
[preferences] module name changed (preferences-contribution)
1867d15 
Fixes: #8203

This PR renames module from 'preference-contribution' to 'preferences-contribution'.

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
minyoungyang added a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
@minyoungyang
[preferences] module name changed (preferences-contribution)
2c7adca 
Fixes: eclipse-theia#8203

This PR renames module from 'preference-contribution' to 'preferences-contribution'.

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good first issues for new contributors preferences issues related to preferences quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
1 participant
@kittaakos