Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete creation of a typescript build task #8950

Closed
alvsan09 opened this issue Jan 14, 2021 · 0 comments · Fixed by #8971
Closed

Incomplete creation of a typescript build task #8950

alvsan09 opened this issue Jan 14, 2021 · 0 comments · Fixed by #8971
Assignees
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@alvsan09
Copy link
Contributor

Bug Description:

When creating a first build task for a typescript project,
the generated tasks.json is incomplete.

Steps to Reproduce:

  1. From a hello world project as shown.
    image

2.Create a default build configuration by selecting the typescript file and then select
Main menu -> Terminal -> Configure Tasks... -> "tsc: build - tsconfig.json"

3.The created configuration will look like:
image

The created task entry may some times be more complete, i.e. the created entry is not consistent.

4.The expected input on the created tasks.json
image

Additional Information

  • Operating System:
  • Theia Version: master branch, commit: 1c84263
@vince-fugnitto vince-fugnitto added bug bugs found in the application tasks issues related to the task system labels Jan 15, 2021
alvsan09 added a commit to alvsan09/theia that referenced this issue Jan 19, 2021
* Added missing group properties to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Jan 19, 2021
* Added missing group properties to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Jan 19, 2021
* Added missing group properties to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Jan 19, 2021
* Added missing group properties to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Jan 20, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Jan 20, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Jan 21, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.
* Align TaskCustomization.group with task schema (i.e. remove 'none'
when 'isDefault').

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Jan 22, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.
* Align TaskCustomization.group with task schema (i.e. remove 'none'
when 'isDefault').

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 1, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.
* Align TaskCustomization.group with task schema (i.e. remove 'none'
when 'isDefault').

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 2, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.
* Align TaskCustomization.group with task schema (i.e. remove 'none'
when 'isDefault').

eclipse-theia#8950

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 3, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.
* Align TaskCustomization.group with task schema (i.e. remove 'none'
when 'isDefault').
* Include task 'label' in the generated task.json

Issues:
eclipse-theia#8950
eclipse-theia#8980

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 3, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.
* Align TaskCustomization.group with task schema (i.e. remove 'none'
when 'isDefault').
* Include task 'label' in the generated task.json

Issues:
eclipse-theia#8950
eclipse-theia#8980

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
vince-fugnitto pushed a commit that referenced this issue Feb 4, 2021
* Added missing 'group' property to the TaskDto interface
* Added group when converting between TaskDto and TaskConfiguration
* Added group when converting between TaskDto and Task
* Removes clearing of problem matchers (error) to pass the received
ones from a given extension.
* Align TaskCustomization.group with task schema (i.e. remove 'none'
when 'isDefault').
* Include task 'label' in the generated task.json

Issues:
#8950
#8980

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants