Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waitForHidden seems to be wrong. #9260

Closed
kgdev opened this issue Mar 26, 2021 · 1 comment · Fixed by #12300
Closed

waitForHidden seems to be wrong. #9260

kgdev opened this issue Mar 26, 2021 · 1 comment · Fixed by #12300
Labels
beginners issues that are perfect for beginners bug bugs found in the application core issues related to the core of the application good first issue good first issues for new contributors quality issues related to code and application quality

Comments

@kgdev
Copy link

kgdev commented Mar 26, 2021 •
edited
Loading

theia/packages/core/src/browser/widgets/widget.ts

Line 282 in d9c0fab

return waitForVisible(widget, true);

Should it be return waitForVisible(widget, false); ?
@vince-fugnitto vince-fugnitto added bug bugs found in the application core issues related to the core of the application quality issues related to code and application quality labels Mar 26, 2021
@vince-fugnitto
Copy link
Member

@kgdev thank you for reporting the issue, I believe you are correct. It is likely that the bug went unnoticed since there are no waitForHidden callers. Nevertheless, would you be interested in providing a pull-request to resolve the issue?

@vince-fugnitto vince-fugnitto added beginners issues that are perfect for beginners good first issue good first issues for new contributors labels Mar 6, 2023
@DerTimonius DerTimonius mentioned this issue Mar 14, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginners issues that are perfect for beginners bug bugs found in the application core issues related to the core of the application good first issue good first issues for new contributors quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix boolean in waitForHidden function
2 participants
@kgdev @vince-fugnitto