Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean in waitForHidden function #12300

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Fix boolean in waitForHidden function #12300

merged 2 commits into from
Mar 30, 2023

Conversation

DerTimonius
Copy link
Contributor

What it does

Fixes #9260

Hi everyone! Thanks for this IDE!
This PR will change the boolean value inside the waitForHidden function from true to false.
I realized that the function is not used anywhere, so if it's better to remove the function altogether, I can change this PR.

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the review guidelines (technically not necessary, since the function is not called anywhere)

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

@DerTimonius
Copy link
Contributor Author

I signed the eca but it's still not validating (messed up the email at first, changed it to the correct, still not working 😐 )

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label Mar 29, 2023
@vince-fugnitto vince-fugnitto merged commit b08dd9d into eclipse-theia:master Mar 30, 2023
@vince-fugnitto vince-fugnitto added this to the 1.36.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waitForHidden seems to be wrong.
2 participants