Improve plugin-view toolbar lifecycle #10546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9075.
Closes #9080.
This PR builds on #9080. That PR addressed a bug in the fetching of values from workspace scope in the
MonacoConfigurationService
, but did not fix the problem with missing events for updating toolbars in plugin-contributed views. This PR makes several changes to address the latter problem:.with
utility from theViewContextKeyService
. That utility was designed to check whether awhen
expression's conditions would be satisfied given certain assumptions, but it caused two or four change events to be fired by theContextKeyService
for every check. It has been replaced by a.with
utility on theMonacoContextKeyService
class that uses Monaco utilities to create subcontexts so that the events don't bubble to the global context..with
utility at all.ContextKeyService
interface from the mostly useless dummy implementation incore
. This is a breaking change (extenders can no longerextends ContextKeyService
), but it allows us to document the functionality of the methods. Previously each method was just annotated withShould be implemented elsewhere
.How to test
Review checklist
Reminder for reviewers