Fix starting pseudoterminal #10780
Merged
Fix starting pseudoterminal #10780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: robmor01 <Rob.Moran@arm.com>
msujew
approved these changes
Feb 21, 2022
colin-grant-work
pushed a commit
to colin-grant-work/theia
that referenced
this pull request
Feb 23, 2022
Signed-off-by: robmor01 <Rob.Moran@arm.com>
federicobozzini
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Aug 24, 2022
Signed-off-by: robmor01 <Rob.Moran@arm.com>
1 task
thegecko
added a commit
to ARMmbed/theia
that referenced
this pull request
Jan 23, 2023
Signed-off-by: robmor01 <Rob.Moran@arm.com> This reverts commit 363e521.
thegecko
added a commit
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: robmor01 Rob.Moran@arm.com
What it does
When using a pseudoterminal, the
$terminalOpened()function interminal-ext.tsshould signal the pseudoterminal to open.This wasn't working because the wrong ID (
terminalID- index of open terminal) was being used to find the pseudoterminal rather than the UUID it was keyed on.This resulted in pseudoterminals not starting.
How to test
Use an extension or plugin which implements a pseudoterminal for emitting data.
I could create an example project, but it would take some time...
Review checklist
Reminder for reviewers