Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: remove deploy plugin by id command #11417

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

Closes: #9510.
Closes: #3632.

Relevant discussion: #11414.

The pull-request removes the Plugin: Deploy Plugin by Id command for the following reasons:

  • no vscode equivalent
  • the behavior is confusing and has a poor user-experience
  • there are better and recommended ways to install plugins at runtime

How to test

  • CI should pass

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added the plug-in system issues related to the plug-in system label Jul 13, 2022
@vince-fugnitto vince-fugnitto requested a review from msujew July 13, 2022 18:21
The commit removes the `Plugin: Deploy Plugin by Id` command since:
- the command does not exist in vscode
- the command is confusing, and not user-friendly
- there are better and recommended ways to install plugins at runtime

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me 👍

@vince-fugnitto vince-fugnitto merged commit f4327c2 into master Jul 27, 2022
@vince-fugnitto vince-fugnitto deleted the vf/deploy-by-id branch July 27, 2022 16:23
@github-actions github-actions bot added this to the 1.28.0 milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the progress of installing a plugin
2 participants