Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up any type uses #11490

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Clean up any type uses #11490

merged 1 commit into from
Aug 4, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 1, 2022

What it does

Removes a lot of any and Object/object references, cleans up the associated eslint-disable comment and replaces each instance with unknown, making the functions more robust against possible type-related issues.

How to test

  1. CI is green and the application continues to work as expected

Review checklist

Reminder for reviewers

@msujew msujew added the quality issues related to code and application quality label Aug 1, 2022
@msujew msujew force-pushed the msujew/any-fixes branch from baff98b to 50a2886 Compare August 1, 2022 11:03
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look mostly good to me, see comments.

I find using any fine as we can often hit TypeScript's type narrowing's limits... But beside that I don't have very strong opinions about using unknown instead of any.

Thanks for the work!

packages/plugin-ext/src/plugin/types-impl.ts Show resolved Hide resolved
packages/plugin-ext/src/plugin/types-impl.ts Show resolved Hide resolved
@msujew msujew force-pushed the msujew/any-fixes branch from fb9f988 to 65d9522 Compare August 4, 2022 21:17
@msujew msujew merged commit e94a923 into master Aug 4, 2022
@msujew msujew deleted the msujew/any-fixes branch August 4, 2022 21:53
@github-actions github-actions bot added this to the 1.29.0 milestone Aug 4, 2022
@msujew msujew mentioned this pull request Nov 3, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants