Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: update default api version to 1.55.2 #11823

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

Closes: #9863.

The pull-request bumps the framework's default supported vscode api version from 1.53.2 to 1.55.2 given that the appropriate apis have been implemented.

How to test

  • CI should successfully pass.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Nov 2, 2022
@vince-fugnitto vince-fugnitto self-assigned this Nov 2, 2022
The commit bumps the framework's default supported api version from
`1.53.2` to `1.55.2` given that the appropriate apis have been
implemented.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll uplift the nls.metadata.json and everything related to that in a follow-up PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gap theia master vs. VS Code 1.55.2
3 participants