-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbars: ToolbarItem.when field is evaluated and respected #12067
Merged
msujew
merged 4 commits into
eclipse-theia:master
from
jonah-iden:jiden/toolbar-items-when-clause-11705
Feb 21, 2023
Merged
Toolbars: ToolbarItem.when field is evaluated and respected #12067
msujew
merged 4 commits into
eclipse-theia:master
from
jonah-iden:jiden/toolbar-items-when-clause-11705
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by toolbar and tab-bar-toolbar + when clause can be set in toolbar.json Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
reviewed
Jan 13, 2023
packages/core/src/browser/shell/tab-bar-toolbar/tab-bar-toolbar.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
packages/core/src/browser/shell/tab-bar-toolbar/tab-bar-toolbar.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/browser/shell/tab-bar-toolbar/tab-bar-toolbar.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/browser/shell/tab-bar-toolbar/tab-bar-toolbar.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me 👍
- Registering a
when
context correctly updates the toolbar item (disables/enables it) - When the context changes, the item is also updated as expected
- A disabled toolbar item will not trigger its command when pressed (though it still allows to remove/move the item)
- The
string
type for thewhen
property is correctly reflected when editing the JSON file
For transparency the pull-request has caused regressions with other toolbar items such as #12314. |
Another regression is described at: |
1 task
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToolbarItem.when field is evaluated and respected
by toolbar and tab-bar-toolbar +
when clause can be set in toolbar.json
Signed-off-by: Jonah Iden jonah.iden@typefox.io
What it does
Implements/fixes #11705
This PR implements the funcitionality for toolbars to evaluate and respect the when field/clause of
ConditionalToolbarItem
.Also allows setting the when field in
toolbar.json
.How to test
easiest way to test is probably through the toolbar.json file:
Review checklist
Reminder for reviewers